-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Farzin/76562/Remove legacy connect
method from cashier
#7238
Merged
carolsachdeva
merged 12 commits into
deriv-com:develop
from
farzin-deriv:farzin/76562/remove_legacy_connect_method_from_cashier
Jan 3, 2023
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
7babd01
refactor(cashier): :fire: remove `mobx-react-lite` from `cashier`
32b4c73
refactor(cashier): :recycle: replace `connect` with `useStore` for re…
73c5b25
refactor(cashier): :recycle: fix test files to use `StoreProvider`
d33218b
refactor(cashier): :fire: remove `connect` from `cashier`
df76fc2
refactor(cashier): :fire: remove extra store related types from `cash…
02f8cfe
fix(stores): :bug: stop persisting the stores when store is unmount
00a5fbd
Merge branch 'develop' into farzin/76562/remove_legacy_connect_method…
631cc10
Merge branch 'develop' into farzin/76562/remove_legacy_connect_method…
745f900
Merge branch 'develop' into farzin/76562/remove_legacy_connect_method…
bc95ae0
Merge branch 'develop' into farzin/76562/remove_legacy_connect_method…
0548085
Merge branch 'develop' into farzin/76562/remove_legacy_connect_method…
4449d6a
Merge branch 'develop' into farzin/76562/remove_legacy_connect_method…
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -3,7 +3,6 @@ import { setWebsocket } from '@deriv/shared'; | |||||
import { StoreProvider } from '@deriv/stores'; | ||||||
import { init } from 'Utils/server_time'; | ||||||
import Routes from 'Containers/routes'; | ||||||
import { MobxContentProvider } from 'Stores/connect'; | ||||||
|
||||||
const App = ({ passthrough: { WS, root_store } }) => { | ||||||
React.useEffect(() => { | ||||||
|
@@ -13,11 +12,9 @@ const App = ({ passthrough: { WS, root_store } }) => { | |||||
}, []); | ||||||
|
||||||
return ( | ||||||
<MobxContentProvider store={root_store}> | ||||||
<StoreProvider store={root_store}> | ||||||
<Routes /> | ||||||
</StoreProvider> | ||||||
</MobxContentProvider> | ||||||
<StoreProvider store={root_store}> | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
Later when we could move all stores to the |
||||||
<Routes /> | ||||||
</StoreProvider> | ||||||
); | ||||||
}; | ||||||
|
||||||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should’ve been
mobx-react-lite
, But seems like we have missed it in merge conflicts and didn’t notice it.