Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Niloofar | Refactor tests in the login-button.spec.tsx file #7245

Conversation

niloofar-deriv
Copy link
Contributor

@niloofar-deriv niloofar-deriv commented Dec 27, 2022

Changes:

Please include a summary of the change and which issue is fixed below:

  • ...

When you need to add unit test

  • If this change disrupt current flow
  • If this change is adding new flow

When you need to add integration test

  • If components from external libraries are being used to define the flow, e.g. @deriv/components
  • If it relies on a very specific set of props with no default behavior for the current component.

Test coverage checklist (for reviewer)

  • Ensure utility / function has a test case
  • Ensure all the tests are passing

Type of change

  • Bug fix
  • New feature
  • Update feature
  • Refactor code
  • Translation to code
  • Translation to crowdin
  • Script configuration
  • Improve performance
  • Style only
  • Dependency update
  • Documentation update
  • Release

@vercel
Copy link

vercel bot commented Dec 27, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
deriv-app ✅ Ready (Inspect) Visit Preview Dec 27, 2022 at 1:24PM (UTC)

@sonarcloud
Copy link

sonarcloud bot commented Dec 27, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@github-actions
Copy link
Contributor

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/7245](https://github.com/binary-com/deriv-app/pull/7245)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-niloo-fs-niloofar-83410refactor-test-file.binary.sx?qa_server=frontend.binaryws.com&app_id=23848
    - **Original**: https://deriv-app-git-fork-niloo-fs-niloofar-83410refactor-test-file.binary.sx
- **App ID**: `23848`

@codecov-commenter
Copy link

Codecov Report

Merging #7245 (6fb9584) into develop (4f74b1e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #7245   +/-   ##
========================================
  Coverage    19.13%   19.13%           
========================================
  Files         1466     1466           
  Lines        34327    34327           
  Branches      6309     6309           
========================================
  Hits          6569     6569           
  Misses       27261    27261           
  Partials       497      497           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@farrah-deriv farrah-deriv merged commit a44342b into deriv-com:develop Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants