Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: summary panel flickering #7321

Conversation

sandeep-deriv
Copy link
Contributor

Changes:

Please include a summary of the change and which issue is fixed below:

  • Fixed summary panel flickering

When you need to add unit test

  • If this change disrupt current flow
  • If this change is adding new flow

When you need to add integration test

  • If components from external libraries are being used to define the flow, e.g. @deriv/components
  • If it relies on a very specific set of props with no default behavior for the current component.

Test coverage checklist (for reviewer)

  • Ensure utility / function has a test case
  • Ensure all the tests are passing

Type of change

  • Bug fix
  • New feature
  • Update feature
  • Refactor code
  • Translation to code
  • Translation to crowdin
  • Script configuration
  • Improve performance
  • Style only
  • Dependency update
  • Documentation update
  • Release

@boring-cyborg boring-cyborg bot added the Bot label Jan 6, 2023
@vercel
Copy link

vercel bot commented Jan 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
deriv-app ✅ Ready (Inspect) Visit Preview Jan 6, 2023 at 10:46AM (UTC)

@sonarcloud
Copy link

sonarcloud bot commented Jan 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
4.0% 4.0% Duplication

@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2023

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/7321](https://github.com/binary-com/deriv-app/pull/7321)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-sandeep-deriv-sandeep-85235fix-summar-71b0c6.binary.sx?qa_server=frontend.binaryws.com&app_id=31560
    - **Original**: https://deriv-app-git-fork-sandeep-deriv-sandeep-85235fix-summar-71b0c6.binary.sx
- **App ID**: `31560`

@codecov-commenter
Copy link

Codecov Report

Merging #7321 (1864514) into master (37266a2) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #7321   +/-   ##
=======================================
  Coverage   19.40%   19.40%           
=======================================
  Files        1478     1478           
  Lines       34569    34569           
  Branches     6366     6366           
=======================================
  Hits         6709     6709           
  Misses      27349    27349           
  Partials      511      511           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@prince-deriv prince-deriv merged commit b134c88 into deriv-com:master Jan 7, 2023
carolsachdeva pushed a commit to carolsachdeva/deriv-app that referenced this pull request Jan 9, 2023
carolsachdeva added a commit that referenced this pull request Jan 9, 2023
* Revert "fix: summary panel flickering (#7321)"

This reverts commit b134c88.

* Revert "translations: 📚 sync translations with crowdin (#7316)"

This reverts commit 37266a2.

* Revert "fix: dbot performance issue -- unified websocket connection and moved… (#7103)"

This reverts commit 1abb7de.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants