Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kate/ 86205/console errors in local host #7428

Merged
merged 1 commit into from
Jan 31, 2023

Conversation

kate-deriv
Copy link
Contributor

Changes:

Delete defaultChecked property in order to make component controlled. Otherwise it caused console error

When you need to add unit test

  • If this change disrupt current flow
  • If this change is adding new flow

When you need to add integration test

  • If components from external libraries are being used to define the flow, e.g. @deriv/components
  • If it relies on a very specific set of props with no default behavior for the current component.

Test coverage checklist (for reviewer)

  • Ensure utility / function has a test case
  • Ensure all the tests are passing

Type of change

  • Bug fix
  • New feature
  • Update feature
  • Refactor code
  • Translation to code
  • Translation to crowdin
  • Script configuration
  • Improve performance
  • Style only
  • Dependency update
  • Documentation update
  • Release

@vercel
Copy link

vercel bot commented Jan 23, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
deriv-app ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 23, 2023 at 1:27PM (UTC)

@sonarcloud
Copy link

sonarcloud bot commented Jan 23, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link
Contributor

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/7428](https://github.com/binary-com/deriv-app/pull/7428)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-kate-deriv-kate-86205consoleerrors.binary.sx?qa_server=frontend.binaryws.com&app_id=23814
    - **Original**: https://deriv-app-git-fork-kate-deriv-kate-86205consoleerrors.binary.sx
- **App ID**: `23814`

@github-actions
Copy link
Contributor

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 17
🟧 Accessibility 88
🟢 Best practices 100
🟧 SEO 85
🟢 PWA 90

Lighthouse ran with https://deriv-app-git-fork-kate-deriv-kate-86205consoleerrors.binary.sx/

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (develop@7ac8c6f). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             develop    #7428   +/-   ##
==========================================
  Coverage           ?   20.36%           
==========================================
  Files              ?     1477           
  Lines              ?    34461           
  Branches           ?     6296           
==========================================
  Hits               ?     7019           
  Misses             ?    26897           
  Partials           ?      545           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@maryia-deriv maryia-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

Copy link
Contributor

@matin-deriv matin-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better to add a proper QA checklist to make sure it does not affect any checkbox in the app as you're changing the main component and it is being reused all over Deriv-app.

@matin-deriv matin-deriv merged commit 4540ad2 into deriv-com:develop Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants