-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kate/ 86205/console errors in local host #7428
kate/ 86205/console errors in local host #7428
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
A production App ID was automatically generated for this PR. (log)
Click here to copy & paste above information.
|
🚨 Lighthouse report for the changes in this PR:
Lighthouse ran with https://deriv-app-git-fork-kate-deriv-kate-86205consoleerrors.binary.sx/ |
Codecov Report
@@ Coverage Diff @@
## develop #7428 +/- ##
==========================================
Coverage ? 20.36%
==========================================
Files ? 1477
Lines ? 34461
Branches ? 6296
==========================================
Hits ? 7019
Misses ? 26897
Partials ? 545 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better to add a proper QA checklist to make sure it does not affect any checkbox in the app as you're changing the main component and it is being reused all over Deriv-app.
Changes:
Delete defaultChecked property in order to make component controlled. Otherwise it caused console error
When you need to add unit test
When you need to add integration test
Test coverage checklist (for reviewer)
Type of change