Aizad/87647/open real dialog issue #7504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
A production App ID was automatically generated for this PR. (log)
Click here to copy & paste above information. |
|
🚨 Lighthouse report for the changes in this PR:
Lighthouse ran with https://deriv-app-git-fork-aizad-deriv-aizad-87647open-real-dial-089ba3.binary.sx/ |
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## master #7504 +/- ##
==========================================
- Coverage 19.87% 19.87% -0.01%
==========================================
Files 1492 1492
Lines 35140 35141 +1
Branches 6433 6434 +1
==========================================
Hits 6985 6985
- Misses 27591 27592 +1
Partials 564 564
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
packages/core/src/App/Components/Elements/Modals/deriv-real-account-required-modal.jsx
Outdated
Show resolved
Hide resolved
thisyahlen-deriv
approved these changes
Feb 3, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
|
⏳ Generating Lighthouse report... |
sergei-deriv
approved these changes
Feb 3, 2023
carolsachdeva
pushed a commit
to carolsachdeva/deriv-app
that referenced
this pull request
Feb 9, 2023
* chore: fix sizing dialog for real account required on appstore * fix: remove console.logs 😅 * fix: remove unused prop types
carolsachdeva
pushed a commit
to carolsachdeva/deriv-app
that referenced
this pull request
Feb 9, 2023
* chore: fix sizing dialog for real account required on appstore * fix: remove console.logs 😅 * fix: remove unused prop types
yashim-deriv
pushed a commit
that referenced
this pull request
Feb 9, 2023
* Thisyahlen/65078/cfd poa test (#7456) * cfd-poa test first commit * removed unused mocks and added a few more test cases * removed unused mocks * removed some test cases and adjusted some * re-arranged some code to lessen the duplication * convered address to an object * refractored the poa test with the new changes * Update cfd-poa.spec.js * test: cfd-poa * fix: regulatory information (#7543) * Revert "fix: regulatory information (#7543)" (#7552) This reverts commit 1ca6b30. * fix: resolved conflicts of develop branch with master * fix: resolved build issues in crypto-transaction-history * Merge remote-tracking branch 'upstream/master' into develop * Amina/ fix: mf_list (#7516) * fix: mf_list * chore: trigger build * Ameerul /Task 74218 Incorrect Deriv P2P Balance Information (#7491) * chore: added info icon and corrected information * chore: fixed modal for mobile and icon * chore: changed text * Aizad/87647/open real dialog issue (#7504) * chore: fix sizing dialog for real account required on appstore * fix: remove console.logs 😅 * fix: remove unused prop types * 87814/fix blank onboarding for non en lang (#7527) * fix: exit traders hub * fix: exit v2 * fix: exit remove async v3 * fix: remove await * fix: blank onboarding page for non_EN languages --------- Co-authored-by: Thisyahlen Nair <thisyahlen@regentmarkets.com> * Henry/86550/feat/change tabs to dropdown reports (#7443) * feat: change from tabs to dropdown menu in reports * fix: changed variable names to contract types instead of trade types * chore: change to more readable classname * feat: ux improvement * chore: deleted unneccesary commented out code * fix: fixing circleCI error * fix: CircleCI bug fix * fix: fix CircleCI Issue * fix: circleCI fix * fix: circleCI fix * chore: fix css naming and use convention * fix: placeholder component was not being shown after closing multiplier contract * fix: multiplier close button cut off in mobile view --------- Co-authored-by: HENRY <henry@regentmarkets.com> * Sergei / 87513 / change create mt5 demo account congratulations text (#7496) * fix: change create mt5 deom account congratulations text * feat: empty * Update packages/cfd/src/Containers/cfd-password-modal.tsx Co-authored-by: amina-deriv <84661147+amina-deriv@users.noreply.github.com> * fix: delete unnecessary spaces --------- Co-authored-by: amina-deriv <84661147+amina-deriv@users.noreply.github.com> * Shayan/80609/components shared ts migration parent (#7294) * checking circle/ci test * removed test changes * feat: 🎨 migrated component to tsx * feat: 🎨 fixed index * feat: 🎨 incorporated single logic for props * feat: 🎨 migrated component to tsx * feat: ♻️ incorporated review comments * feat: 🎨 remoed comments * feat: migrated index file * feat: migrated index file * feat: 🎨 migrated comeponent to tsx * feat: 🎨 incorporated type * feat: 🎨 incorporated type * feat: ♻️ incorporated review comments * yauheni/76888/icontradetypes ts migration * feat: 🐛 resolved fialing testcase * ts migration for idv expired * feat: 🎨 migrated pageoverlay to tsx * feat: 🐛 import statement fix * feat: 🎨 migrated tooltip to tsx * remove .jsx from idv-epired index.js * feat: ♻️ incorporated review comments * feat: ♻️ incorporated review comments * ts migration for idv-rejected * update any to unknown in globals.d.ts * revert back to any to solve error * refactor: formcancelbutton ts migration * trigger * refactor: ts migration for idv-submit-complete * refactor: ts migration for idv-verified * refactor: ts migration for idv-verified.spec.tsx * feat: 🎨 migrated select-native to tsx * feat: ♻️ incorporated review comments * feat: 🎨 Replaced Fragment tag * feat: 🎨 reduced typecasting * refactor: ts migration for idv-limited.jsx * fix: remove idv-limited.jsx from index.js * feat: 🎨 migrated component to tsx * Mobile Drawer migration * Children Props change * feat: ♻️ incorporated review comments * feat: ♻️ incorporated review comments * Fix for drag drawer * Error fixes * feat: 🎨 migrated component to tsx * feat: ♻️ incorporated review comments * feat: 🎨 migrate component to TSX * Sanjam/76937/TS_Migration_TickPicker * refactor: prop fix * Padstart fix * Made chnages to make some properties optional * feat: 🐛 fixed label type * optional sub-header fix * removed parseInt from the state * feat: 🐛 resolved import statements * Made the props change * Pr fix * refactor: ts migration for missing-personal-detals * refactor: ts migration for missing-personal-details * refactor: ts migration for missing-personal-details * TS Migration Inline Icon with Tests * refactor: ts migration for poi/limited * Removed unused declarations * feat: ♻️ incorporated comments * refactor: ts migration for poi/expired * fix: conflicts * fix: resolve cooonflicts * fix: resolve conflicts * fix: resolve conflicts * fix: resolve conflicts * feat: 🎨 migrated component * refactor: ts migration for card-with-arrow * refactor: ts migration for card-with-arrow * refactor: ts migration for constants.js * Passwordmeter * Sanjam/ TS migration Password meter * Converted message ti react node * Uneccessary child props * Reverted spec changes * refactor: apply changes on globals.d.ts * refactor: changed open_chat_window to packages/core/globals.d.ts * refactor: ts migration for documents * fix: remove .jsx * fix: resolve conflicts * Export removed * MIgrated Password Meter component * Fixes * fix: removed prop types * fix: empty * fix: build * fix: build * fix: build * fix: extra file removed * fix: resolve conflicts * fix: make has_close_icon to be optional * fix: duplicated item * fix: tests and buikd fix * refactor: change HTMLElement to ReactElement and remove propTypes * fix: build fix * fix: fixing ts error[WIP] * fix: fixed file-dropzone ts error * fix: fixed ts errors * fix: removed any * fix: refactored useOnClickOutside hook to fix ts errors * fix: fixed the codecov failing * fix: fixed ts errors --------- Co-authored-by: shayan khaleghparast <iman@firstsource.tech> Co-authored-by: Shayan Khaleghparast <100833613+iman-fs@users.noreply.github.com> Co-authored-by: Likhith Kolayari <likhith@regentmarkets.com> Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> Co-authored-by: tay suisin <suisin@regentmarkets.com> Co-authored-by: sanjam chhatwal <sanjam@deriv.com> Co-authored-by: sanjam-deriv <99465624+sanjam-deriv@users.noreply.github.com> * hamid/84403/add-mockStore-object-for-test-usage (#7440) * feat: add mockStore object for test usage * feat: use mockStore in withdrawal.spec.tsx * chore: retrigged the test * fix: failed tests fix * fix: failed tests fix * feat: add new properties to mockStore * fix: missing types in mockStore * Hubert / fixing IDV validation (#7372) * chore: fixing IDV validation * chore: refactoring code --------- Co-authored-by: Hubert Koster <hubertkoster@Hubert-Kosters-MacBook-Pro-C02F1N65MD6M.local> * fix: console error on edit ad where payment method is disabled from bo (#7427) * Kate/80001/Remove unused query params from the URL on initialize (#7447) * fix: add check for specific unused params in query * refactor: rename const, lift them up, move logic to a separate self declared function * fix: change the passing value for excludeParamsFromUrlQuery function * Rostislav / 86373 / Bug fix for side note on cashier page going missing once we navigate to different tabs like Withdrawal, Payments agents (#7416) * refactor: init pr * fix: bug fixed (by correctly timing adding side notes) * Ameerul /Bug 86546 P2P clients (Not POI verified clients) are not temp. banned when we block temporary until 14th of next month or any further dates. (#7444) * chore: revert * chore: added comment * Farzin/87456/Extract `is_onramp_tab_visible` method from cashier `OnRampStore` to reusable hook (#7475) * feat(core): ✨ add `is_crypto` method to `ClientStore` * feat(hooks): ✨ add `useOnrampVisible` hook * refactor(cashier): ♻️ replace `is_onramp_tab_visible` with `useOnrampVisible` * refactor(core): ♻️ replace `is_onramp_tab_visible` with `useOnrampVisible` * docs(cashier): 🗑️ deprecated legacy `is_onramp_tab_visible` method --------- Co-authored-by: Farzin Mirzaie <farzin@deriv.com> * chore: updated the readme file (#7388) * chore: updated the readme file * chore: updated readme * chore: updated build:one in readme * fix: updated build:one in readme * hamid/86888/refactor-hook-test-files-to-use-testing-library-react-hooks (#7448) * feat: enhance the tests with react-hooks testing library * feat: enhance the tests with react-hooks testing library * feat: refactor useCountdown store test * feat: refactor useSubscription store test * feat: refactor store test * fix: fix pr comments * fix: fix pr comments * fix: issue with payment method search filter (#7426) * fix: issue with payment method search filter * fix: no search results found state not getting cleared on closing modal * fix(stores): 💚 add missing default value to `mockStore` (#7535) Co-authored-by: Farzin Mirzaie <farzin@deriv.com> * translations: 📚 sync translations with crowdin (#7537) Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com> * hotfix: contract details for digits trade types from open positions were showing error (#7550) Co-authored-by: HENRY <henry@regentmarkets.com> Co-authored-by: Carol Sachdeva <58209918+carol-deriv@users.noreply.github.com> * translations: 📚 sync translations with crowdin (#7546) Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com> Co-authored-by: Carol Sachdeva <58209918+carol-deriv@users.noreply.github.com> * chore: added setpreferredlanguage in trading-hub-header and exit-traders-hub-modal (#7553) * Farzin/85472/R&D/Remove `CashierStore` initialization from core package (#7278) * refactor(cashier): 🔥 remove `mobx-react-lite` from `cashier` * refactor(cashier): ♻️ replace `connect` with `useStore` for remaining components * refactor(cashier): ♻️ fix test files to use `StoreProvider` * refactor(cashier): 🔥 remove `connect` from `cashier` * refactor(cashier): 🔥 remove extra store related types from `cashier` * fix(stores): 🐛 stop persisting the stores when store is unmount * feat(cashier): ✨ add `useCashierStore` hook * refactor(cashier): ♻️ replace `modules.cashier` with `useCashierStore` hook * refactor(cashier): ♻️ remove `useStore` hook return type override * fix(cashier): 📝 resolve PR conflicts * test(cashier): ✅ fix the tests * chore(cashier): 🚚 rename `cashier_providers.tsx` to `cashier-providers.tsx` * Shayan/52349/react17 migration (#6908) * refactor: react version is upgraded to version 17 * fix: fixed typo * fix: changed declaration file location * fix: temporarily commented our two test cases that are failing * fix: fixed react-content-loader props * fix: fixed some bugs * fix: fixed z-index issue for popover in DBot page * fix: fixed popover position issue in DBot page * chore: an small change on how to turn string to array * fix: merge upstream develop into my branch and resolved conflicts * fix: resolved pr comments * fix: removed rc-drawer and refactored mobile drawer * fix: fixed test cases * fix: resolved pr comments * fix: resolved pr comment * fix: fixed typo * fix: resolved pr comments * fix: fixed slide-in component bug * fix: resolved pr comments * fix: resolved pr comments * fix: removed unnecessary lines * fix: resolved pr comments * Update packages/account/src/Components/personal-details/__tests__/personal-details.spec.js Co-authored-by: Niloofar Sadeghi <93518187+niloo-fs@users.noreply.github.com> * Update packages/account/src/Components/personal-details/__tests__/personal-details.spec.js Co-authored-by: Niloofar Sadeghi <93518187+niloo-fs@users.noreply.github.com> * Update packages/account/src/Components/personal-details/personal-details.jsx Co-authored-by: Niloofar Sadeghi <93518187+niloo-fs@users.noreply.github.com> * fix: fixed mt5 modal not appear on screen when clicking on trade button * fix: fixed Bug #84787 Co-authored-by: Shayan Khaleghparast <100833613+iman-fs@users.noreply.github.com> Co-authored-by: Niloofar Sadeghi <93518187+niloo-fs@users.noreply.github.com> * test(cashier): ✅ fix the tests * test(cashier): ✅ fix the tests * fix: add optional chaining in getMinDuration function (#7344) * fix: 🐛 resolved issue with trade. odal (#7291) * feat(api): 🧑💻 improve `@deriv/api` typings * chore(cashier): ✏️ fix React 17 type issue with `PropsWithChildren` * Revert "fix: 🐛 resolved issue with trade. odal (#7291)" (#7364) This reverts commit b6f7e4c. * Farzin/85054/Call `resetWithrawForm` on `CryptoWithdrawForm` component `onunmount` (#7331) * fix(cashier): 🐛 call `resetWithrawForm` on `CryptoWithdrawForm` component `onunmount` * test(cashier): ✅ fix failing test Co-authored-by: Farzin Mirzaie <farzin@deriv.com> * Niloofar Sadeghi / Task - Refactor tests in the language.spec.js file (#7325) * refactor: language tests * fix: typo Co-authored-by: Niloofar Sadeghi <niloofar.sadeghi@firstsource.tech> * refactor: proposal tests (#7327) Co-authored-by: Niloofar Sadeghi <niloofar.sadeghi@firstsource.tech> * Niloofar Sadeghi / Task - Refactor tests in the error.spec.js file (#7324) * refactor: errors validator tests * fix: typo Co-authored-by: Niloofar Sadeghi <niloofar.sadeghi@firstsource.tech> * Niloofar Sadeghi / Task - Refactor tests in the binary-link.spec.tsx file (#7288) * refactor: binary-link tests * refactor: improve testids namings Co-authored-by: Niloofar Sadeghi <niloofar.sadeghi@firstsource.tech> * refactor: money tests (#7353) * refactor: toggle-positions tests (#7287) Co-authored-by: Niloofar Sadeghi <niloofar.sadeghi@firstsource.tech> * refactor: toggle-button tests (#7328) Co-authored-by: Niloofar Sadeghi <niloofar.sadeghi@firstsource.tech> * Niloofar Sadeghi / Task - Refactor tests in the toggle-button-group.spec.tsx file (#7330) * refactor: toggle-button-group tests * fix: test issue Co-authored-by: Niloofar Sadeghi <niloofar.sadeghi@firstsource.tech> * refactor: open-positions-table tests (#7374) * Niloofar Sadeghi / Task - Refactor tests in the marker-spot-label.spec.tsx file (#7355) * refactor: remove extra files from reports * refactor: marker-spot-label tests * Niloofar Sadeghi / Task - Refactor tests in the binary-link.spec.tsx file (#7286) * refactor: binary-link tests * test: added more tests Co-authored-by: Niloofar Sadeghi <niloofar.sadeghi@firstsource.tech> * Niloofar Sadeghi / Task - Refactor tests in the contract-type-dialog.spec.tsx file (#7285) * refactor: contract-type-dialog tests * test: added more tests * fix: circle/ci issue Co-authored-by: Niloofar Sadeghi <niloofar.sadeghi@firstsource.tech> * Niloofar Sadeghi / Task - Refactor tests in the platform-dropdown.spec.tsx file (#7282) * refactor: platform-dropdown tests * refactor: improve testids namings Co-authored-by: Niloofar Sadeghi <niloofar.sadeghi@firstsource.tech> Co-authored-by: Farzin Mirzaie <farzin@deriv.com> Co-authored-by: Shayan Khaleghparast <100833613+shayan-deriv@users.noreply.github.com> Co-authored-by: Shayan Khaleghparast <100833613+iman-fs@users.noreply.github.com> Co-authored-by: Niloofar Sadeghi <93518187+niloo-fs@users.noreply.github.com> Co-authored-by: kate-deriv <121025168+kate-deriv@users.noreply.github.com> Co-authored-by: Likhith Kolayari <98398322+likhith-deriv@users.noreply.github.com> Co-authored-by: Farrah Mae Ochoa <farrah@deriv.com> Co-authored-by: Matin shafiei <matin@deriv.com> Co-authored-by: Niloofar Sadeghi <93518187+niloofar-deriv@users.noreply.github.com> Co-authored-by: Niloofar Sadeghi <niloofar.sadeghi@firstsource.tech> * fix prettier * Revert "Thisyahlen/65078/cfd poa test (#7456)" This reverts commit 4ed287c. --------- Co-authored-by: thisyahlen <104053934+thisyahlen-deriv@users.noreply.github.com> Co-authored-by: mahdiyeh-deriv <82078941+mahdiyeh-deriv@users.noreply.github.com> Co-authored-by: vinu-deriv <vinu@deriv.com> Co-authored-by: amina-deriv <84661147+amina-deriv@users.noreply.github.com> Co-authored-by: ameerul-deriv <103412909+ameerul-deriv@users.noreply.github.com> Co-authored-by: aizad-deriv <103104395+aizad-deriv@users.noreply.github.com> Co-authored-by: Thisyahlen Nair <thisyahlen@regentmarkets.com> Co-authored-by: henry-deriv <118344354+henry-deriv@users.noreply.github.com> Co-authored-by: HENRY <henry@regentmarkets.com> Co-authored-by: Sergei Baranovski <120570511+sergei-deriv@users.noreply.github.com> Co-authored-by: Shayan Khaleghparast <100833613+shayan-deriv@users.noreply.github.com> Co-authored-by: shayan khaleghparast <iman@firstsource.tech> Co-authored-by: Shayan Khaleghparast <100833613+iman-fs@users.noreply.github.com> Co-authored-by: Likhith Kolayari <likhith@regentmarkets.com> Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> Co-authored-by: tay suisin <suisin@regentmarkets.com> Co-authored-by: sanjam chhatwal <sanjam@deriv.com> Co-authored-by: sanjam-deriv <99465624+sanjam-deriv@users.noreply.github.com> Co-authored-by: Hamid <hamid@deriv.com> Co-authored-by: hubert-deriv <80688204+hubert-deriv@users.noreply.github.com> Co-authored-by: Hubert Koster <hubertkoster@Hubert-Kosters-MacBook-Pro-C02F1N65MD6M.local> Co-authored-by: nada-deriv <122768621+nada-deriv@users.noreply.github.com> Co-authored-by: kate-deriv <121025168+kate-deriv@users.noreply.github.com> Co-authored-by: Rostik Kayko <119863957+rostislav-deriv@users.noreply.github.com> Co-authored-by: Farzin Mirzaie <72082844+farzin-deriv@users.noreply.github.com> Co-authored-by: Farzin Mirzaie <farzin@deriv.com> Co-authored-by: Sandeep Rajput <90243468+sandeep-deriv@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com> Co-authored-by: Niloofar Sadeghi <93518187+niloo-fs@users.noreply.github.com> Co-authored-by: Likhith Kolayari <98398322+likhith-deriv@users.noreply.github.com> Co-authored-by: Farrah Mae Ochoa <farrah@deriv.com> Co-authored-by: Matin shafiei <matin@deriv.com> Co-authored-by: Niloofar Sadeghi <93518187+niloofar-deriv@users.noreply.github.com> Co-authored-by: Niloofar Sadeghi <niloofar.sadeghi@firstsource.tech>
bahar-sadeghzadeh
pushed a commit
to bahar-sadeghzadeh/deriv-app
that referenced
this pull request
Feb 20, 2023
* Thisyahlen/65078/cfd poa test (deriv-com#7456) * cfd-poa test first commit * removed unused mocks and added a few more test cases * removed unused mocks * removed some test cases and adjusted some * re-arranged some code to lessen the duplication * convered address to an object * refractored the poa test with the new changes * Update cfd-poa.spec.js * test: cfd-poa * fix: regulatory information (deriv-com#7543) * Revert "fix: regulatory information (deriv-com#7543)" (deriv-com#7552) This reverts commit 1ca6b30. * fix: resolved conflicts of develop branch with master * fix: resolved build issues in crypto-transaction-history * Merge remote-tracking branch 'upstream/master' into develop * Amina/ fix: mf_list (deriv-com#7516) * fix: mf_list * chore: trigger build * Ameerul /Task 74218 Incorrect Deriv P2P Balance Information (deriv-com#7491) * chore: added info icon and corrected information * chore: fixed modal for mobile and icon * chore: changed text * Aizad/87647/open real dialog issue (deriv-com#7504) * chore: fix sizing dialog for real account required on appstore * fix: remove console.logs 😅 * fix: remove unused prop types * 87814/fix blank onboarding for non en lang (deriv-com#7527) * fix: exit traders hub * fix: exit v2 * fix: exit remove async v3 * fix: remove await * fix: blank onboarding page for non_EN languages --------- Co-authored-by: Thisyahlen Nair <thisyahlen@regentmarkets.com> * Henry/86550/feat/change tabs to dropdown reports (deriv-com#7443) * feat: change from tabs to dropdown menu in reports * fix: changed variable names to contract types instead of trade types * chore: change to more readable classname * feat: ux improvement * chore: deleted unneccesary commented out code * fix: fixing circleCI error * fix: CircleCI bug fix * fix: fix CircleCI Issue * fix: circleCI fix * fix: circleCI fix * chore: fix css naming and use convention * fix: placeholder component was not being shown after closing multiplier contract * fix: multiplier close button cut off in mobile view --------- Co-authored-by: HENRY <henry@regentmarkets.com> * Sergei / 87513 / change create mt5 demo account congratulations text (deriv-com#7496) * fix: change create mt5 deom account congratulations text * feat: empty * Update packages/cfd/src/Containers/cfd-password-modal.tsx Co-authored-by: amina-deriv <84661147+amina-deriv@users.noreply.github.com> * fix: delete unnecessary spaces --------- Co-authored-by: amina-deriv <84661147+amina-deriv@users.noreply.github.com> * Shayan/80609/components shared ts migration parent (deriv-com#7294) * checking circle/ci test * removed test changes * feat: 🎨 migrated component to tsx * feat: 🎨 fixed index * feat: 🎨 incorporated single logic for props * feat: 🎨 migrated component to tsx * feat: ♻️ incorporated review comments * feat: 🎨 remoed comments * feat: migrated index file * feat: migrated index file * feat: 🎨 migrated comeponent to tsx * feat: 🎨 incorporated type * feat: 🎨 incorporated type * feat: ♻️ incorporated review comments * yauheni/76888/icontradetypes ts migration * feat: 🐛 resolved fialing testcase * ts migration for idv expired * feat: 🎨 migrated pageoverlay to tsx * feat: 🐛 import statement fix * feat: 🎨 migrated tooltip to tsx * remove .jsx from idv-epired index.js * feat: ♻️ incorporated review comments * feat: ♻️ incorporated review comments * ts migration for idv-rejected * update any to unknown in globals.d.ts * revert back to any to solve error * refactor: formcancelbutton ts migration * trigger * refactor: ts migration for idv-submit-complete * refactor: ts migration for idv-verified * refactor: ts migration for idv-verified.spec.tsx * feat: 🎨 migrated select-native to tsx * feat: ♻️ incorporated review comments * feat: 🎨 Replaced Fragment tag * feat: 🎨 reduced typecasting * refactor: ts migration for idv-limited.jsx * fix: remove idv-limited.jsx from index.js * feat: 🎨 migrated component to tsx * Mobile Drawer migration * Children Props change * feat: ♻️ incorporated review comments * feat: ♻️ incorporated review comments * Fix for drag drawer * Error fixes * feat: 🎨 migrated component to tsx * feat: ♻️ incorporated review comments * feat: 🎨 migrate component to TSX * Sanjam/76937/TS_Migration_TickPicker * refactor: prop fix * Padstart fix * Made chnages to make some properties optional * feat: 🐛 fixed label type * optional sub-header fix * removed parseInt from the state * feat: 🐛 resolved import statements * Made the props change * Pr fix * refactor: ts migration for missing-personal-detals * refactor: ts migration for missing-personal-details * refactor: ts migration for missing-personal-details * TS Migration Inline Icon with Tests * refactor: ts migration for poi/limited * Removed unused declarations * feat: ♻️ incorporated comments * refactor: ts migration for poi/expired * fix: conflicts * fix: resolve cooonflicts * fix: resolve conflicts * fix: resolve conflicts * fix: resolve conflicts * feat: 🎨 migrated component * refactor: ts migration for card-with-arrow * refactor: ts migration for card-with-arrow * refactor: ts migration for constants.js * Passwordmeter * Sanjam/ TS migration Password meter * Converted message ti react node * Uneccessary child props * Reverted spec changes * refactor: apply changes on globals.d.ts * refactor: changed open_chat_window to packages/core/globals.d.ts * refactor: ts migration for documents * fix: remove .jsx * fix: resolve conflicts * Export removed * MIgrated Password Meter component * Fixes * fix: removed prop types * fix: empty * fix: build * fix: build * fix: build * fix: extra file removed * fix: resolve conflicts * fix: make has_close_icon to be optional * fix: duplicated item * fix: tests and buikd fix * refactor: change HTMLElement to ReactElement and remove propTypes * fix: build fix * fix: fixing ts error[WIP] * fix: fixed file-dropzone ts error * fix: fixed ts errors * fix: removed any * fix: refactored useOnClickOutside hook to fix ts errors * fix: fixed the codecov failing * fix: fixed ts errors --------- Co-authored-by: shayan khaleghparast <iman@firstsource.tech> Co-authored-by: Shayan Khaleghparast <100833613+iman-fs@users.noreply.github.com> Co-authored-by: Likhith Kolayari <likhith@regentmarkets.com> Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> Co-authored-by: tay suisin <suisin@regentmarkets.com> Co-authored-by: sanjam chhatwal <sanjam@deriv.com> Co-authored-by: sanjam-deriv <99465624+sanjam-deriv@users.noreply.github.com> * hamid/84403/add-mockStore-object-for-test-usage (deriv-com#7440) * feat: add mockStore object for test usage * feat: use mockStore in withdrawal.spec.tsx * chore: retrigged the test * fix: failed tests fix * fix: failed tests fix * feat: add new properties to mockStore * fix: missing types in mockStore * Hubert / fixing IDV validation (deriv-com#7372) * chore: fixing IDV validation * chore: refactoring code --------- Co-authored-by: Hubert Koster <hubertkoster@Hubert-Kosters-MacBook-Pro-C02F1N65MD6M.local> * fix: console error on edit ad where payment method is disabled from bo (deriv-com#7427) * Kate/80001/Remove unused query params from the URL on initialize (deriv-com#7447) * fix: add check for specific unused params in query * refactor: rename const, lift them up, move logic to a separate self declared function * fix: change the passing value for excludeParamsFromUrlQuery function * Rostislav / 86373 / Bug fix for side note on cashier page going missing once we navigate to different tabs like Withdrawal, Payments agents (deriv-com#7416) * refactor: init pr * fix: bug fixed (by correctly timing adding side notes) * Ameerul /Bug 86546 P2P clients (Not POI verified clients) are not temp. banned when we block temporary until 14th of next month or any further dates. (deriv-com#7444) * chore: revert * chore: added comment * Farzin/87456/Extract `is_onramp_tab_visible` method from cashier `OnRampStore` to reusable hook (deriv-com#7475) * feat(core): ✨ add `is_crypto` method to `ClientStore` * feat(hooks): ✨ add `useOnrampVisible` hook * refactor(cashier): ♻️ replace `is_onramp_tab_visible` with `useOnrampVisible` * refactor(core): ♻️ replace `is_onramp_tab_visible` with `useOnrampVisible` * docs(cashier): 🗑️ deprecated legacy `is_onramp_tab_visible` method --------- Co-authored-by: Farzin Mirzaie <farzin@deriv.com> * chore: updated the readme file (deriv-com#7388) * chore: updated the readme file * chore: updated readme * chore: updated build:one in readme * fix: updated build:one in readme * hamid/86888/refactor-hook-test-files-to-use-testing-library-react-hooks (deriv-com#7448) * feat: enhance the tests with react-hooks testing library * feat: enhance the tests with react-hooks testing library * feat: refactor useCountdown store test * feat: refactor useSubscription store test * feat: refactor store test * fix: fix pr comments * fix: fix pr comments * fix: issue with payment method search filter (deriv-com#7426) * fix: issue with payment method search filter * fix: no search results found state not getting cleared on closing modal * fix(stores): 💚 add missing default value to `mockStore` (deriv-com#7535) Co-authored-by: Farzin Mirzaie <farzin@deriv.com> * translations: 📚 sync translations with crowdin (deriv-com#7537) Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com> * hotfix: contract details for digits trade types from open positions were showing error (deriv-com#7550) Co-authored-by: HENRY <henry@regentmarkets.com> Co-authored-by: Carol Sachdeva <58209918+carol-deriv@users.noreply.github.com> * translations: 📚 sync translations with crowdin (deriv-com#7546) Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com> Co-authored-by: Carol Sachdeva <58209918+carol-deriv@users.noreply.github.com> * chore: added setpreferredlanguage in trading-hub-header and exit-traders-hub-modal (deriv-com#7553) * Farzin/85472/R&D/Remove `CashierStore` initialization from core package (deriv-com#7278) * refactor(cashier): 🔥 remove `mobx-react-lite` from `cashier` * refactor(cashier): ♻️ replace `connect` with `useStore` for remaining components * refactor(cashier): ♻️ fix test files to use `StoreProvider` * refactor(cashier): 🔥 remove `connect` from `cashier` * refactor(cashier): 🔥 remove extra store related types from `cashier` * fix(stores): 🐛 stop persisting the stores when store is unmount * feat(cashier): ✨ add `useCashierStore` hook * refactor(cashier): ♻️ replace `modules.cashier` with `useCashierStore` hook * refactor(cashier): ♻️ remove `useStore` hook return type override * fix(cashier): 📝 resolve PR conflicts * test(cashier): ✅ fix the tests * chore(cashier): 🚚 rename `cashier_providers.tsx` to `cashier-providers.tsx` * Shayan/52349/react17 migration (deriv-com#6908) * refactor: react version is upgraded to version 17 * fix: fixed typo * fix: changed declaration file location * fix: temporarily commented our two test cases that are failing * fix: fixed react-content-loader props * fix: fixed some bugs * fix: fixed z-index issue for popover in DBot page * fix: fixed popover position issue in DBot page * chore: an small change on how to turn string to array * fix: merge upstream develop into my branch and resolved conflicts * fix: resolved pr comments * fix: removed rc-drawer and refactored mobile drawer * fix: fixed test cases * fix: resolved pr comments * fix: resolved pr comment * fix: fixed typo * fix: resolved pr comments * fix: fixed slide-in component bug * fix: resolved pr comments * fix: resolved pr comments * fix: removed unnecessary lines * fix: resolved pr comments * Update packages/account/src/Components/personal-details/__tests__/personal-details.spec.js Co-authored-by: Niloofar Sadeghi <93518187+niloo-fs@users.noreply.github.com> * Update packages/account/src/Components/personal-details/__tests__/personal-details.spec.js Co-authored-by: Niloofar Sadeghi <93518187+niloo-fs@users.noreply.github.com> * Update packages/account/src/Components/personal-details/personal-details.jsx Co-authored-by: Niloofar Sadeghi <93518187+niloo-fs@users.noreply.github.com> * fix: fixed mt5 modal not appear on screen when clicking on trade button * fix: fixed Bug #84787 Co-authored-by: Shayan Khaleghparast <100833613+iman-fs@users.noreply.github.com> Co-authored-by: Niloofar Sadeghi <93518187+niloo-fs@users.noreply.github.com> * test(cashier): ✅ fix the tests * test(cashier): ✅ fix the tests * fix: add optional chaining in getMinDuration function (deriv-com#7344) * fix: 🐛 resolved issue with trade. odal (deriv-com#7291) * feat(api): 🧑💻 improve `@deriv/api` typings * chore(cashier): ✏️ fix React 17 type issue with `PropsWithChildren` * Revert "fix: 🐛 resolved issue with trade. odal (deriv-com#7291)" (deriv-com#7364) This reverts commit b6f7e4c. * Farzin/85054/Call `resetWithrawForm` on `CryptoWithdrawForm` component `onunmount` (deriv-com#7331) * fix(cashier): 🐛 call `resetWithrawForm` on `CryptoWithdrawForm` component `onunmount` * test(cashier): ✅ fix failing test Co-authored-by: Farzin Mirzaie <farzin@deriv.com> * Niloofar Sadeghi / Task - Refactor tests in the language.spec.js file (deriv-com#7325) * refactor: language tests * fix: typo Co-authored-by: Niloofar Sadeghi <niloofar.sadeghi@firstsource.tech> * refactor: proposal tests (deriv-com#7327) Co-authored-by: Niloofar Sadeghi <niloofar.sadeghi@firstsource.tech> * Niloofar Sadeghi / Task - Refactor tests in the error.spec.js file (deriv-com#7324) * refactor: errors validator tests * fix: typo Co-authored-by: Niloofar Sadeghi <niloofar.sadeghi@firstsource.tech> * Niloofar Sadeghi / Task - Refactor tests in the binary-link.spec.tsx file (deriv-com#7288) * refactor: binary-link tests * refactor: improve testids namings Co-authored-by: Niloofar Sadeghi <niloofar.sadeghi@firstsource.tech> * refactor: money tests (deriv-com#7353) * refactor: toggle-positions tests (deriv-com#7287) Co-authored-by: Niloofar Sadeghi <niloofar.sadeghi@firstsource.tech> * refactor: toggle-button tests (deriv-com#7328) Co-authored-by: Niloofar Sadeghi <niloofar.sadeghi@firstsource.tech> * Niloofar Sadeghi / Task - Refactor tests in the toggle-button-group.spec.tsx file (deriv-com#7330) * refactor: toggle-button-group tests * fix: test issue Co-authored-by: Niloofar Sadeghi <niloofar.sadeghi@firstsource.tech> * refactor: open-positions-table tests (deriv-com#7374) * Niloofar Sadeghi / Task - Refactor tests in the marker-spot-label.spec.tsx file (deriv-com#7355) * refactor: remove extra files from reports * refactor: marker-spot-label tests * Niloofar Sadeghi / Task - Refactor tests in the binary-link.spec.tsx file (deriv-com#7286) * refactor: binary-link tests * test: added more tests Co-authored-by: Niloofar Sadeghi <niloofar.sadeghi@firstsource.tech> * Niloofar Sadeghi / Task - Refactor tests in the contract-type-dialog.spec.tsx file (deriv-com#7285) * refactor: contract-type-dialog tests * test: added more tests * fix: circle/ci issue Co-authored-by: Niloofar Sadeghi <niloofar.sadeghi@firstsource.tech> * Niloofar Sadeghi / Task - Refactor tests in the platform-dropdown.spec.tsx file (deriv-com#7282) * refactor: platform-dropdown tests * refactor: improve testids namings Co-authored-by: Niloofar Sadeghi <niloofar.sadeghi@firstsource.tech> Co-authored-by: Farzin Mirzaie <farzin@deriv.com> Co-authored-by: Shayan Khaleghparast <100833613+shayan-deriv@users.noreply.github.com> Co-authored-by: Shayan Khaleghparast <100833613+iman-fs@users.noreply.github.com> Co-authored-by: Niloofar Sadeghi <93518187+niloo-fs@users.noreply.github.com> Co-authored-by: kate-deriv <121025168+kate-deriv@users.noreply.github.com> Co-authored-by: Likhith Kolayari <98398322+likhith-deriv@users.noreply.github.com> Co-authored-by: Farrah Mae Ochoa <farrah@deriv.com> Co-authored-by: Matin shafiei <matin@deriv.com> Co-authored-by: Niloofar Sadeghi <93518187+niloofar-deriv@users.noreply.github.com> Co-authored-by: Niloofar Sadeghi <niloofar.sadeghi@firstsource.tech> * fix prettier * Revert "Thisyahlen/65078/cfd poa test (deriv-com#7456)" This reverts commit 4ed287c. --------- Co-authored-by: thisyahlen <104053934+thisyahlen-deriv@users.noreply.github.com> Co-authored-by: mahdiyeh-deriv <82078941+mahdiyeh-deriv@users.noreply.github.com> Co-authored-by: vinu-deriv <vinu@deriv.com> Co-authored-by: amina-deriv <84661147+amina-deriv@users.noreply.github.com> Co-authored-by: ameerul-deriv <103412909+ameerul-deriv@users.noreply.github.com> Co-authored-by: aizad-deriv <103104395+aizad-deriv@users.noreply.github.com> Co-authored-by: Thisyahlen Nair <thisyahlen@regentmarkets.com> Co-authored-by: henry-deriv <118344354+henry-deriv@users.noreply.github.com> Co-authored-by: HENRY <henry@regentmarkets.com> Co-authored-by: Sergei Baranovski <120570511+sergei-deriv@users.noreply.github.com> Co-authored-by: Shayan Khaleghparast <100833613+shayan-deriv@users.noreply.github.com> Co-authored-by: shayan khaleghparast <iman@firstsource.tech> Co-authored-by: Shayan Khaleghparast <100833613+iman-fs@users.noreply.github.com> Co-authored-by: Likhith Kolayari <likhith@regentmarkets.com> Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> Co-authored-by: tay suisin <suisin@regentmarkets.com> Co-authored-by: sanjam chhatwal <sanjam@deriv.com> Co-authored-by: sanjam-deriv <99465624+sanjam-deriv@users.noreply.github.com> Co-authored-by: Hamid <hamid@deriv.com> Co-authored-by: hubert-deriv <80688204+hubert-deriv@users.noreply.github.com> Co-authored-by: Hubert Koster <hubertkoster@Hubert-Kosters-MacBook-Pro-C02F1N65MD6M.local> Co-authored-by: nada-deriv <122768621+nada-deriv@users.noreply.github.com> Co-authored-by: kate-deriv <121025168+kate-deriv@users.noreply.github.com> Co-authored-by: Rostik Kayko <119863957+rostislav-deriv@users.noreply.github.com> Co-authored-by: Farzin Mirzaie <72082844+farzin-deriv@users.noreply.github.com> Co-authored-by: Farzin Mirzaie <farzin@deriv.com> Co-authored-by: Sandeep Rajput <90243468+sandeep-deriv@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com> Co-authored-by: Niloofar Sadeghi <93518187+niloo-fs@users.noreply.github.com> Co-authored-by: Likhith Kolayari <98398322+likhith-deriv@users.noreply.github.com> Co-authored-by: Farrah Mae Ochoa <farrah@deriv.com> Co-authored-by: Matin shafiei <matin@deriv.com> Co-authored-by: Niloofar Sadeghi <93518187+niloofar-deriv@users.noreply.github.com> Co-authored-by: Niloofar Sadeghi <niloofar.sadeghi@firstsource.tech>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Please include a summary of the change and which issue is fixed below:
When you need to add unit test
When you need to add integration test
Test coverage checklist (for reviewer)
Type of change