-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Likhith/87594/trigger onfido checks for high risk client #7646
Likhith/87594/trigger onfido checks for high risk client #7646
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
A production App ID was automatically generated for this PR. (log)
Click here to copy & paste above information.
|
🚨 Lighthouse report for the changes in this PR:
Lighthouse ran with https://deriv-app-git-fork-likhith-deriv-likhith-87594trigger-on-5c66e3.binary.sx/ |
…ecks-for-high-risk-client
@@ -90,7 +100,6 @@ const CFDDbviOnboarding = ({ | |||
} | |||
// eslint-disable-next-line react-hooks/exhaustive-deps | |||
}, [is_cfd_verification_modal_visible]); | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why did you delete here the empty line? :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Honestly nt sure :)
@@ -745,6 +745,10 @@ export default class ClientStore extends BaseStore { | |||
return this.account_status?.status?.includes('dxtrade_password_not_set'); | |||
} | |||
|
|||
get is_authenticated_with_idv_photoid() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add this to 'computed'?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, I am filtering out a particular account status and returning it. So when account status object changes, this value is re-computed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report
@@ Coverage Diff @@
## master #7646 +/- ##
======================================
Coverage 0.05% 0.05%
======================================
Files 117 117
Lines 3425 3425
Branches 893 893
======================================
Hits 2 2
Misses 3423 3423 |
import React from 'react'; | ||
import { useStore } from '@deriv/stores'; | ||
|
||
const AccountStatusList = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we move this to a util file instead of this hook?
@farzin-deriv can we import the list from shared or util package here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@matin-deriv What would be the benefit of it? 🤔
can we import the list from shared or util package here?
From @deriv/utils
yes but from @deriv/shared
no 👀
⏳ Generating Lighthouse report... |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
|
||
export const useIsAccountStatusPresent = (status: TAccountStatus) => { | ||
const { | ||
client: { account_status }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@likhith-deriv I think this dependency on client-store can be removed once useAccountStatus
hook is introduced in this PR
) * feat: added onfido check for high risk client * feat: ⚡ Incorporated POA for Labuan when status is idv_photoid * fix: failing testcase * feat: reverted the change * feat: added missing config * feat: added POA * feat: ✨ added POA trigger for IDV+photot status * fix: ♻️ incorporated review comments * chore: incorporated review comments * feat: ✨ incorporated IDV revoked status * refactor: ♻️ refactored code * refactor: ♻️ incorporated review comments * feat: ♻️ incorporated review comments * feat: resolved issue with POA * fix: 🐛 Trigger POA only in user is idv+photo verified for labuan * fix: ✨ incorporated Resubmission triggers * feat: incorporated testcases * chore: trigger rebuild * fix: resolved issue with POA trigger for idv+photo clients * chore: 💚 trigger build * fix: 🐛 resolved bugs regd high risk DBVI account * Likhith/incorporate deriv hooks (#42) * feat: ✨ installed deriv-hooks * feat: ✨ incorporated a new hook * fix: ✅ added testcase * feat: incorporated hook * fix: 🎨 reverted changes of hooks implementation * fix: ⚡ added testcases --------- Co-authored-by: Matin shafiei <matin@deriv.com>
Changes:
Please include a summary of the change and which issue is fixed below:
When you need to add unit test
When you need to add integration test
Test coverage checklist (for reviewer)
Type of change