farrah/90734/fix: notification for completed orders

[farrah-deriv]

Changes:

Please include a summary of the change and which issue is fixed below:

• Fixed the toast notification not showing for completed orders

When you need to add unit test

• If this change disrupt current flow
• If this change is adding new flow

When you need to add integration test

• If components from external libraries are being used to define the flow, e.g. @deriv/components
• If it relies on a very specific set of props with no default behavior for the current component.

Test coverage checklist (for reviewer)

• Ensure utility / function has a test case
• Ensure all the tests are passing

Type of change

• Bug fix
• New feature
• Update feature
• Refactor code
• Translation to code
• Translation to crowdin
• Script configuration
• Improve performance
• Style only
• Dependency update
• Documentation update
• Release

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
deriv-app	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Apr 24, 2023 9:00am

[github-actions]

A production App ID was automatically generated for this PR. (log)

• PR: farrah/90734/fix: notification for completed orders #8000
• URLs:
  • w/ App ID + Server: https://deriv-app-git-fork-farrah-deriv-completed-order-notification.binary.sx?qa_server=red.binaryws.com&app_id=32108
  • Original: https://deriv-app-git-fork-farrah-deriv-completed-order-notification.binary.sx
• App ID: 32108

Click here to copy & paste above information.

- **PR**: [https://github.com/binary-com/deriv-app/pull/8000](https://github.com/binary-com/deriv-app/pull/8000)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-farrah-deriv-completed-order-notification.binary.sx?qa_server=red.binaryws.com&app_id=32108
    - **Original**: https://deriv-app-git-fork-farrah-deriv-completed-order-notification.binary.sx
- **App ID**: `32108`

[github-actions]

🚨 Lighthouse report for the changes in this PR:

Category	Score
🔺 Performance	21
🟧 Accessibility	75
🟢 Best practices	92
🟧 SEO	85
🟢 PWA	90

Lighthouse ran with https://deriv-app-git-fork-farrah-deriv-completed-order-notification.binary.sx/

[ameerul-deriv]

LGTM

[codecov-commenter]

Codecov Report

Merging #8000 (033e36b) into master (48875e4) will increase coverage by 0.00%.
The diff coverage is 10.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##           master    #8000   +/-   ##
=======================================
  Coverage   20.73%   20.73%           
=======================================
  Files        1539     1539           
  Lines       35918    35917    -1     
  Branches     7013     7012    -1     
=======================================
  Hits         7447     7447           
+ Misses      27751    27750    -1     
  Partials      720      720           

Impacted Files	Coverage Δ
...e/src/App/Containers/app-notification-messages.jsx	0.00% <0.00%> (ø)
packages/core/src/Stores/notification-store.js	0.00% <0.00%> (ø)
packages/p2p/src/components/app.jsx	0.00% <ø> (ø)
...p2p/src/components/order-details/order-details.jsx	0.00% <ø> (ø)
.../components/orders/order-table/order-table-row.jsx	0.00% <0.00%> (ø)
packages/p2p/src/stores/general-store.js	0.00% <0.00%> (ø)
packages/p2p/src/stores/order-store.js	0.00% <0.00%> (ø)
...ages/cashier/src/pages/p2p-cashier/p2p-cashier.tsx	73.46% <100.00%> (ø)

... and 4 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
3.1% Duplication