-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shaheer/Suisin/Amina/feature/90115/update jurisdiction #8093
Merged
bahar-sadeghzadeh
merged 339 commits into
deriv-com:master
from
amina-deriv:amina/feature/90115/update_jurisdiction
Jun 1, 2023
Merged
Changes from 239 commits
Commits
Show all changes
339 commits
Select commit
Hold shift + click to select a range
2c1da0a
Merge pull request #6 from amina-deriv/amina/feature/90115/update_jur…
shaheer-deriv a365912
Merge branch 'shaheer/feature/90115/update_jurisdiction' into shaheer…
shaheer-deriv a9bac37
refactor: :pencil2: renames a type
shaheer-deriv 35ad751
refactor: :art: improves code structure by removing unwanted return s…
shaheer-deriv 94d6b60
refactor: :art: organises jurisdiction contents to seperate folder
shaheer-deriv a4b0c42
refactor: :pencil2: renames a type
shaheer-deriv 53c5add
refactor: :sparkles: converts jurisdiction object to functions for tr…
shaheer-deriv 7d751a4
Merge branch 'binary-com:master' into amina/feature/90115/update_juri…
shaheer-deriv 259f48a
Merge branch 'binary-com:master' into shaheer/feature/90115/update_ju…
shaheer-deriv 50f1c2d
Merge branch 'binary-com:master' into shaheer/90804/mt5-jurisdiction-…
shaheer-deriv 869a7a6
refactor: :lipstick: nests sass classes
shaheer-deriv 66a26ad
refactor: :lipstick: nests sass classes
shaheer-deriv 7409988
refactor: :art: uses border radius constant value in css
shaheer-deriv 7f7fac2
refactor: :art: refactors css property usages
shaheer-deriv b37583c
refactor: :pencil2: renames a key in mt5 contents
shaheer-deriv 524dceb
refactor: :art: refactors mt5 code
shaheer-deriv 2d9afde
refactor: :art: sorts color constants used
shaheer-deriv 592a9a4
refactor: :art: refactors color usages
shaheer-deriv c23e84b
Merge branch 'binary-com:master' into amina/feature/90115/update_juri…
shaheer-deriv 533606f
Merge pull request #7 from amina-deriv/amina/feature/90115/update_jur…
shaheer-deriv 4bab9ff
Merge branch 'shaheer/feature/90115/update_jurisdiction' into shaheer…
shaheer-deriv bf8d3b4
Merge branch 'binary-com:master' into shaheer/feature/90115/update_ju…
shaheer-deriv b3fcdbc
Merge branch 'binary-com:master' into shaheer/90804/mt5-jurisdiction-…
shaheer-deriv e0ecd30
Merge branch 'binary-com:master' into amina/feature/90115/update_juri…
shaheer-deriv 3c25502
Merge pull request #8 from amina-deriv/amina/feature/90115/update_jur…
shaheer-deriv 034aefd
Merge branch 'shaheer/feature/90115/update_jurisdiction' into shaheer…
shaheer-deriv 8e0e6af
Merge pull request #49 from shaheer-deriv/shaheer/90804/mt5-jurisdict…
amina-deriv e72b4d6
Merge pull request #9 from amina-deriv/amina/feature/90115/update_jur…
shaheer-deriv ce65b71
fix: :bug: prevents states of child card being destroyed by parent
shaheer-deriv 2053456
Merge branch 'amina/feature/90115/update_jurisdiction' of github.com:…
suisin-deriv 7478cef
refactor: :wastebasket: cleans up jurisdiction code
shaheer-deriv 6ef14bd
chore: update Test Case for Jurisdiction modal content
suisin-deriv 9533259
refactor: :art: moves state down the tree from parent to local level
shaheer-deriv ff565a4
feat: :sparkles: animates jurisdiction card on flip
shaheer-deriv 2bb3eec
feat: :sparkles: displays 'Added' indicator if the card is already added
shaheer-deriv fde6d0e
chore: test case for jurisdiction modal content
suisin-deriv d6536d0
chore: update jurisdiction_selected_shortcode for foot note
suisin-deriv 6c3f5c9
chore: update import to follow document
suisin-deriv f2cf54b
style: :lipstick: fixes the height
shaheer-deriv 879660f
Merge branch 'binary-com:master' into amina/feature/90115/update_juri…
shaheer-deriv 1d15b9e
Merge branch 'binary-com:master' into shaheer/feature/90115/update_ju…
shaheer-deriv f2ecb34
Merge branch 'binary-com:master' into shaheer/90807/jurisdiction-card…
shaheer-deriv 1714a78
Merge branch 'binary-com:master' into shaheer/90807/mt5-jurisdiction-…
shaheer-deriv 4f73b31
Merge branch 'shaheer/90807/mt5-jurisdiction-card' into shaheer/90807…
shaheer-deriv 2aea226
Merge pull request #10 from amina-deriv/amina/feature/90115/update_ju…
shaheer-deriv 68b8d54
Merge branch 'shaheer/feature/90115/update_jurisdiction' into shaheer…
shaheer-deriv 77e505f
chore: test case for jurisdiction card front
suisin-deriv ae3e07d
chore: remove hard coded parts
suisin-deriv 92b77f6
chore: move the imports variable according to documentation
suisin-deriv 7c441a1
style: :lipstick: styles the back of the card as per figma design
shaheer-deriv 5e5302b
refactor: :pencil2: rearranges import statements
shaheer-deriv 8f38263
chore: included checks for MF clients and high risk clients
suisin-deriv a6a5236
chore: updated test case based on comments
suisin-deriv 79d7d75
refactor: :wastebasket: removes unwanted css classes
shaheer-deriv 62fb1e3
refactor: :art: moved classNames into single object
shaheer-deriv a5fa344
refactor: :art: rearranges import statements
shaheer-deriv d4c8658
chore: updated logic for test cases
suisin-deriv 07611c4
chore: update test case in footnote
suisin-deriv 2507582
refactor: :art: sorts props alphabetically
shaheer-deriv 5b9ef6a
refactor: :art: reuses the prop object
shaheer-deriv a5d3aa7
refactor: :pencil2: sorts props alphabetically
shaheer-deriv f881a59
refactor: :art: uses single object for classnames
shaheer-deriv 191c651
style: :lipstick: aligns card sections equally
shaheer-deriv 1ba5b58
Merge branch 'binary-com:master' into amina/feature/90115/update_juri…
shaheer-deriv 7e675ed
Merge branch 'binary-com:master' into shaheer/90807/jurisdiction-card…
shaheer-deriv ba98ede
feat: :sparkles: sets up displaying verification icons in card front
shaheer-deriv a38613f
refactor: :art: sorts props alphabetically
shaheer-deriv e07216c
refactor: :art: adds verification items to props
shaheer-deriv 2d3226c
feat: :sparkles: displays verification icons on card front
shaheer-deriv 3a8d812
Merge branch 'binary-com:master' into shaheer/90807/jurisdiction-card…
shaheer-deriv c68bc20
Merge branch 'binary-com:master' into amina/feature/90115/update_juri…
shaheer-deriv 6937c6d
Merge pull request #11 from amina-deriv/amina/feature/90115/update_ju…
shaheer-deriv abe12fa
Merge branch 'shaheer/feature/90115/update_jurisdiction' into shaheer…
shaheer-deriv e316a16
Merge branch 'binary-com:master' into amina/feature/90115/update_juri…
shaheer-deriv acba460
Merge pull request #53 from suisin-deriv/suisin/92035/test_case_for_j…
amina-deriv 4350d5b
Merge branch 'binary-com:master' into amina/feature/90115/update_juri…
shaheer-deriv dcf07ab
Merge pull request #12 from amina-deriv/amina/feature/90115/update_ju…
shaheer-deriv eb87804
Merge branch 'shaheer/feature/90115/update_jurisdiction' into shaheer…
shaheer-deriv c19a9ec
chore: test case for jurisdiction title indicator
suisin-deriv 1b02756
Merge branch 'amina/feature/90115/update_jurisdiction' of github.com:…
suisin-deriv db96606
Merge branch 'binary-com:master' into amina/feature/90115/update_juri…
shaheer-deriv 6deebf8
Merge branch 'binary-com:master' into shaheer/90807/jurisdiction-card…
shaheer-deriv 3674ee9
Merge branch 'binary-com:master' into shaheer/90807/jurisdiction-card…
shaheer-deriv fe991a2
feat: :sparkles: adds icons for various verification status
shaheer-deriv cba7745
refactor: :art: adds account_status to components
shaheer-deriv 8d31b16
Merge branch 'binary-com:master' into amina/feature/90115/update_juri…
shaheer-deriv 749659a
Merge branch 'binary-com:master' into shaheer/90807/jurisdiction-card…
shaheer-deriv fd7e75b
Merge pull request #13 from amina-deriv/amina/feature/90115/update_ju…
shaheer-deriv e738b91
Merge branch 'shaheer/feature/90115/update_jurisdiction' into shaheer…
shaheer-deriv 6cb80d6
refactor: :art: adds type_of_card props to components
shaheer-deriv 7d6c87a
fix: :lipstick: fixes icon to text alignment
shaheer-deriv 5183e24
chore: test case for jurisdiction card section
suisin-deriv 46cab5a
chore: update code to check test over header not in test case
suisin-deriv ec0109e
feat: :sparkles: displays verification icons based on status
shaheer-deriv 4ecc32d
Merge pull request #54 from suisin-deriv/suisin/93477/test_case_for_j…
amina-deriv cb425dd
chore: test case for jurisdiction clickable description
suisin-deriv b26250d
Merge branch 'binary-com:master' into amina/feature/90115/update_juri…
shaheer-deriv 5bb8c8a
Merge pull request #14 from amina-deriv/amina/feature/90115/update_ju…
shaheer-deriv 13d65a0
style: :lipstick: fixes jurisdiction modal width
shaheer-deriv da90022
Merge branch 'binary-com:master' into shaheer/90807/jurisdiction-card…
shaheer-deriv 3b6a6a0
Merge branch 'shaheer/feature/90115/update_jurisdiction' into shaheer…
shaheer-deriv 69f7cd1
fix: :bug: jurisdiction testcase fix
shaheer-deriv 8e0ab0a
fix: :lipstick: fixes modal height clipping
shaheer-deriv ae445fc
fix: :lipstick: fixes modal card heights
shaheer-deriv 8e3b66d
refactor: :pencil2: renames a type variable
shaheer-deriv 3bb0da5
refactor: :wastebasket: removes unused text value
shaheer-deriv dc88aed
chore: test case for jurisdiction card
suisin-deriv c0d8b24
style: :lipstick: refactors styling
shaheer-deriv 9aa892a
Merge branch 'binary-com:master' into amina/feature/90115/update_juri…
shaheer-deriv 9658700
Merge pull request #15 from amina-deriv/amina/feature/90115/update_ju…
shaheer-deriv 3be6fed
Merge pull request #16 from shaheer-deriv/shaheer/feature/90115/updat…
shaheer-deriv 22dd454
Merge pull request #52 from shaheer-deriv/shaheer/90807/jurisdiction-…
matin-deriv ee7b488
Merge pull request #17 from amina-deriv/amina/feature/90115/update_ju…
shaheer-deriv 0e6edc6
Merge branch 'amina/feature/90115/update_jurisdiction' of github.com:…
suisin-deriv f1b61bb
fix: :bug: fixes firefox flipped card issue
shaheer-deriv db89e7f
chore: updated test case based on new changes
suisin-deriv 48ee27b
Merge branch 'amina/feature/90115/update_jurisdiction' of github.com:…
suisin-deriv 4dc36fa
chore: update test case based on latest update
suisin-deriv d8f7683
chore: remove hard coded variables
suisin-deriv 7689a63
Merge branch 'amina/feature/90115/update_jurisdiction' of github.com:…
suisin-deriv 83b784f
Merge branch 'amina/feature/90115/update_jurisdiction' of github.com:…
suisin-deriv e59ab35
chore: edit test case based on latest update
suisin-deriv 5005abb
chore: test case for jurisdiction card back
suisin-deriv 5464453
Merge branch 'binary-com:master' into amina/feature/90115/update_juri…
shaheer-deriv a747e0f
Merge branch 'binary-com:master' into shaheer/feature/90115/update_ju…
shaheer-deriv c599e65
fix: :bug: fixes crossbrowser support issues
shaheer-deriv 18057c6
Merge branch 'shaheer/feature/90115/update_jurisdiction' of https://g…
shaheer-deriv 406b9d3
Merge branch 'binary-com:master' into amina/feature/90115/update_juri…
shaheer-deriv cec8896
Merge pull request #18 from amina-deriv/amina/feature/90115/update_ju…
shaheer-deriv 4c070dc
Merge pull request #61 from shaheer-deriv/shaheer/feature/90115/updat…
matin-deriv 2257fb5
chore: update code based on comment
suisin-deriv 0a91fd9
chore: remove as const from code
suisin-deriv ae2b971
chore: remove as const from code
suisin-deriv 50069cf
chore: remove object type declaration for data-testid
suisin-deriv b5b57c8
chore: added extra check for className for clickable description
suisin-deriv 76947b0
Merge branch 'binary-com:master' into amina/feature/90115/update_juri…
shaheer-deriv 1c491a5
Merge pull request #19 from amina-deriv/amina/feature/90115/update_ju…
shaheer-deriv 8365d5f
chore: remove all as const
suisin-deriv 071ce45
chore: remove as const from code base
suisin-deriv 875850e
refactor: :recycle: refactors the code
shaheer-deriv 5b15629
refactor: :recycle: refactors jurisdiction localize usages
shaheer-deriv 5e60bd9
Merge pull request #62 from shaheer-deriv/shaheer/feature/90115/updat…
matin-deriv 1ad0572
Merge pull request #60 from suisin-deriv/suisin/jurisdiction_card_bac…
matin-deriv 87bcb02
Merge pull request #56 from suisin-deriv/suisin/93480/test_case_for_j…
matin-deriv 39a96c6
Merge pull request #57 from suisin-deriv/suisin/93478/test_case_for_j…
matin-deriv de37b21
Merge pull request #58 from suisin-deriv/suisin/93479/test_case_for_j…
matin-deriv 883a181
Merge pull request #59 from suisin-deriv/suisin/92038/test_case_for_j…
matin-deriv fbd75c9
Merge branch 'binary-com:master' into amina/feature/90115/update_juri…
shaheer-deriv 0000ffc
Merge branch 'master' into amina/feature/90115/update_jurisdiction
matin-deriv f3525bf
Merge branch 'master' into amina/feature/90115/update_jurisdiction
suisin-deriv b6881c7
Merge branch 'binary-com:master' into amina/feature/90115/update_juri…
shaheer-deriv 7870b2e
Merge branch 'binary-com:master' into amina/feature/90115/update_juri…
shaheer-deriv b323bf7
Merge branch 'master' into amina/feature/90115/update_jurisdiction
shaheer-deriv 5bf9d35
Merge branch 'master' into amina/feature/90115/update_jurisdiction
shaheer-deriv 22972df
Merge pull request #22 from amina-deriv/amina/feature/90115/update_ju…
shaheer-deriv 99392b9
refactor: 🎨 uses existing color for Text component
shaheer-deriv 7a5ec10
perf: :zap: optimizes svg icons
shaheer-deriv 5ba7aa9
Merge pull request #63 from shaheer-deriv/shaheer/feature/90115/updat…
shaheer-deriv 8f66bd0
Merge branch 'binary-com:master' into amina/feature/90115/update_juri…
shaheer-deriv 8509055
Merge branch 'binary-com:master' into amina/feature/90115/update_juri…
shaheer-deriv 6704425
Merge branch 'master' into amina/feature/90115/update_jurisdiction
matin-deriv dd53ac7
chore: remove secret from currency-selector
suisin-deriv e8df579
Merge branch 'amina/feature/90115/update_jurisdiction' of github.com:…
suisin-deriv 29f2f5f
Merge branch 'master' into amina/feature/90115/update_jurisdiction
suisin-deriv 292ad69
Merge branch 'amina/feature/90115/update_jurisdiction' of github.com:…
suisin-deriv cd15c91
Merge pull request #64 from suisin-deriv/suisin/remove_hardcoded_secret
matin-deriv ee1b487
Merge branch 'binary-com:master' into amina/feature/90115/update_juri…
shaheer-deriv 7c1945c
refactor: :pencil2: renames css variable
shaheer-deriv 3310b4a
chore: fix code smells issue
suisin-deriv f382e2b
Merge pull request #65 from suisin-deriv/suisin/solve_code_smells_issue
suisin-deriv 171c00a
refactor: :pencil2: renames jurisdiction content getter funcs
shaheer-deriv 8969de4
refactor: :lipstick: uses BORDER_RADIUS constant in css
shaheer-deriv e91936a
refactor: :art: uses react MouseEvent instead of SyntheticEvent
shaheer-deriv b3d969b
refactor: :art: uses hook via React namespace
shaheer-deriv 1d81ab3
Merge branch 'master' into amina/feature/90115/update_jurisdiction
suisin-deriv c6ef3c4
chore: update code based on comments
suisin-deriv d7eab5c
Merge pull request #66 from suisin-deriv/suisin/resolve_commented_PR
suisin-deriv eb28654
Merge branch 'master' into amina/feature/90115/update_jurisdiction
shaheer-deriv 5fdb287
Merge branch 'binary-com:master' into amina/feature/90115/update_juri…
shaheer-deriv c3dcc98
Merge branch 'master' into amina/feature/90115/update_jurisdiction
shaheer-deriv 8c76e17
Merge branch 'master' into amina/feature/90115/update_jurisdiction
shaheer-deriv 5f3e3ab
Merge branch 'master' into amina/feature/90115/update_jurisdiction
shaheer-deriv 47ba18c
Merge branch 'master' into amina/feature/90115/update_jurisdiction
shaheer-deriv 1f7afc8
Merge branch 'binary-com:master' into amina/feature/90115/update_juri…
shaheer-deriv 16ca57c
Merge branch 'binary-com:master' into amina/feature/90115/update_juri…
shaheer-deriv 6300d90
fix: :bug: removes gradient effect from jurisdiction card
shaheer-deriv 2946ebd
Merge pull request #27 from amina-deriv/amina/feature/90115/update_ju…
shaheer-deriv b8f2181
Merge branch 'binary-com:master' into amina/feature/90115/update_juri…
shaheer-deriv ff5aae2
fix: :bug: updates verification docs icons for vanuatu
shaheer-deriv 08a75e3
fix: :bug: displays the correct icon on card
shaheer-deriv f6d637b
Merge branch 'binary-com:master' into shaheer/WALL-604/onfido-updates
shaheer-deriv 54bdd0e
Merge branch 'binary-com:master' into amina/feature/90115/update_juri…
shaheer-deriv 6f6835e
Merge pull request #69 from amina-deriv/amina/feature/90115/update_ju…
shaheer-deriv 6f7faa0
fix: :bug: fixes onfido verification screens
shaheer-deriv 0c1d868
Merge branch 'master' into amina/feature/90115/update_jurisdiction
shaheer-deriv d54f2e5
Merge branch 'amina/feature/90115/update_jurisdiction' into shaheer/W…
shaheer-deriv 732d91b
fix: :bug: fixes circleci issues
shaheer-deriv eb68da8
fix: :bug: verification icons update based on onfido
shaheer-deriv 823cb70
Merge branch 'master' into amina/feature/90115/update_jurisdiction
shaheer-deriv 3260f4f
fix: :bug: inlcudes onfido verification case for all cards
shaheer-deriv b4b7d27
Merge branch 'binary-com:master' into shaheer/WALL-604/onfido-updates
shaheer-deriv c419119
Merge pull request #70 from amina-deriv/amina/feature/90115/update_ju…
shaheer-deriv 6a71fbe
refactor: :pencil2: adds default prop value for is_onfido_design
shaheer-deriv 67979f0
Merge pull request #67 from amina-deriv/shaheer/WALL-604/onfido-updates
shaheer-deriv a81c74d
Merge branch 'master' into amina/feature/90115/update_jurisdiction
shaheer-deriv 58f5c18
style: :lipstick: adjusts card width as per figma design
shaheer-deriv fd8b8c3
Revert "style: :lipstick: adjusts card width as per figma design"
shaheer-deriv 26ace1d
fix: :bug: displays card text as per figma design
shaheer-deriv 5e22832
Merge pull request #71 from amina-deriv/shaheer/WALL-525/card-styling…
shaheer-deriv c14323d
Merge branch 'binary-com:master' into amina/feature/90115/update_juri…
shaheer-deriv e5b1c3a
Merge branch 'binary-com:master' into amina/feature/90115/update_juri…
shaheer-deriv 2585e53
Merge pull request #28 from amina-deriv/amina/feature/90115/update_ju…
shaheer-deriv 4abb87b
Merge branch 'master' into amina/feature/90115/update_jurisdiction
shaheer-deriv c0e77e4
Merge branch 'binary-com:master' into amina/feature/90115/update_juri…
shaheer-deriv 7da2544
Merge pull request #30 from amina-deriv/amina/feature/90115/update_ju…
shaheer-deriv de97112
fix: :bug: fixes labuan assets value
shaheer-deriv 4e38fd6
style: :lipstick: fixes hover effect for added cards
shaheer-deriv 202d61b
fix: :bug: adds disabled prop for flipped card
shaheer-deriv 601cecf
test: :test_tube: adds missing prop to jurisdiction testcase
shaheer-deriv 4e7a608
Merge branch 'master' into amina/feature/90115/update_jurisdiction
hirad-deriv bfb7363
Merge pull request #74 from shaheer-deriv/shaheer/feature/90115/updat…
hirad-deriv 0db522f
test: :test_tube: fixes circleci test
shaheer-deriv c9b1044
Merge pull request #32 from amina-deriv/amina/feature/90115/update_ju…
shaheer-deriv 946731a
Merge branch 'master' into shaheer/feature/90115/update_jurisdiction
shaheer-deriv ff677f5
test: :test_tube: fixes testcases for swapfree merge
shaheer-deriv 322d6cc
feat: :sparkles: includes swap free to new design
shaheer-deriv 79fb4d0
style: :lipstick: fixes modal width for swap free
shaheer-deriv 68d3b28
refactor: :wastebasket: refactors and cleans the code
shaheer-deriv f876202
Merge branch 'binary-com:master' into shaheer/feature/90115/update_ju…
shaheer-deriv b1034dd
Merge branch 'binary-com:master' into shaheer/feature/90115/update_ju…
shaheer-deriv 74e753c
Merge pull request #75 from shaheer-deriv/shaheer/feature/90115/updat…
shaheer-deriv 960d85b
Merge branch 'master' into amina/feature/90115/update_jurisdiction
shaheer-deriv 3c8cb72
Merge branch 'master' into amina/feature/90115/update_jurisdiction
amina-deriv 2311678
Merge pull request #33 from amina-deriv/amina/feature/90115/update_ju…
shaheer-deriv 47c7b2f
Merge branch 'master' into amina/feature/90115/update_jurisdiction
amina-deriv 8d19714
fix: empty_commit_to_trigger_build
amina-deriv 47d9077
refactor: :pencil2: renames variable to avoid ambiguity
shaheer-deriv 7223b71
refactor: :test_tube: removes duplicate testcase mockprops
shaheer-deriv 75bef86
Merge pull request #76 from shaheer-deriv/shaheer/feature/90115/updat…
shaheer-deriv ea8ac5d
Merge branch 'master' into amina/feature/90115/update_jurisdiction
amina-deriv d2b543e
Merge pull request #34 from amina-deriv/amina/feature/90115/update_ju…
shaheer-deriv 8ce4136
test: :test_tube: adds swap-free related tests to jurisdiction modal
shaheer-deriv 974aa5a
Merge pull request #77 from shaheer-deriv/shaheer/feature/90115/updat…
shaheer-deriv f8d3f10
chore: update test case declare function
suisin-deriv dd30695
Merge branch 'amina/feature/90115/update_jurisdiction' of github.com:…
suisin-deriv da0279d
chore: solve circi issue
suisin-deriv 227267b
Merge pull request #78 from suisin-deriv/suisin/fix_test_case_for_jur…
suisin-deriv 4ecb467
Merge branch 'master' into amina/feature/90115/update_jurisdiction
amina-deriv c66f332
chore: :test_tube: fixes circleci issue
shaheer-deriv a06ddb9
Merge branch 'master' into amina/feature/90115/update_jurisdiction
amina-deriv File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have 25.5% duplication. I suggest you create an improvement card to fix this issue later. Other than that everything LGTM.