Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

likhith/fix: 🐛 fixed Risk assessment warning dual popup issue #8118

Conversation

likhith-deriv
Copy link
Contributor

Changes:

Please include a summary of the change and which issue is fixed below:

  • ...

When you need to add unit test

  • If this change disrupt current flow
  • If this change is adding new flow

When you need to add integration test

  • If components from external libraries are being used to define the flow, e.g. @deriv/components
  • If it relies on a very specific set of props with no default behavior for the current component.

Test coverage checklist (for reviewer)

  • Ensure utility / function has a test case
  • Ensure all the tests are passing

Type of change

  • Bug fix
  • New feature
  • Update feature
  • Refactor code
  • Translation to code
  • Translation to crowdin
  • Script configuration
  • Improve performance
  • Style only
  • Dependency update
  • Documentation update
  • Release

@boring-cyborg boring-cyborg bot added the Core label Apr 3, 2023
@vercel
Copy link

vercel bot commented Apr 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 4, 2023 6:44am

@github-actions
Copy link
Contributor

github-actions bot commented Apr 3, 2023

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/8118](https://github.com/binary-com/deriv-app/pull/8118)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-likhith-deriv-likhith-92491two-risk-a-6f77b1.binary.sx?qa_server=frontend.binaryws.com&app_id=32482
    - **Original**: https://deriv-app-git-fork-likhith-deriv-likhith-92491two-risk-a-6f77b1.binary.sx
- **App ID**: `32482`

@github-actions
Copy link
Contributor

github-actions bot commented Apr 3, 2023

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 21
🟧 Accessibility 75
🟢 Best practices 100
🟧 SEO 85
🟢 PWA 90

Lighthouse ran with https://deriv-app-git-fork-likhith-deriv-likhith-92491two-risk-a-6f77b1.binary.sx/

amina-deriv
amina-deriv previously approved these changes Apr 3, 2023
@codecov-commenter
Copy link

codecov-commenter commented Apr 3, 2023

Codecov Report

Merging #8118 (a0e596e) into master (a003ac7) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master    #8118      +/-   ##
==========================================
- Coverage   20.54%   20.54%   -0.01%     
==========================================
  Files        1531     1531              
  Lines       35826    35827       +1     
  Branches     6991     6992       +1     
==========================================
  Hits         7362     7362              
- Misses      27762    27763       +1     
  Partials      702      702              
Impacted Files Coverage Δ
...Components/financial-details/financial-details.jsx 100.00% <ø> (ø)
...rading-assessment/risk-tolerance-warning-modal.jsx 0.00% <0.00%> (ø)
...ainers/Modals/trading-assessment-existing-user.jsx 0.00% <ø> (ø)
...ntainers/RealAccountSignup/real-account-signup.jsx 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

matin-deriv
matin-deriv previously approved these changes Apr 4, 2023
@sonarcloud
Copy link

sonarcloud bot commented Apr 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
1.1% 1.1% Duplication

@github-actions
Copy link
Contributor

github-actions bot commented Apr 4, 2023

Generating Lighthouse report...

@hamid-deriv hamid-deriv merged commit 1a8ef82 into deriv-com:master Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants