Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

thisyahlen/chore: add test coverage for regulators-switcher component #8320

Conversation

thisyahlen-deriv
Copy link
Contributor

Changes:

Please include a summary of the change and which issue is fixed below:

  • ...

When you need to add unit test

  • If this change disrupt current flow
  • If this change is adding new flow

When you need to add integration test

  • If components from external libraries are being used to define the flow, e.g. @deriv/components
  • If it relies on a very specific set of props with no default behavior for the current component.

Test coverage checklist (for reviewer)

  • Ensure utility / function has a test case
  • Ensure all the tests are passing

Type of change

  • Bug fix
  • New feature
  • Update feature
  • Refactor code
  • Translation to code
  • Translation to crowdin
  • Script configuration
  • Improve performance
  • Style only
  • Dependency update
  • Documentation update
  • Release

@vercel
Copy link

vercel bot commented Apr 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 1, 2023 11:02am

@github-actions
Copy link
Contributor

github-actions bot commented Apr 20, 2023

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/8320](https://github.com/binary-com/deriv-app/pull/8320)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-thisyahlen-deriv-thisyahlen-wall-430t-c30e22.binary.sx?qa_server=red.binaryws.com&app_id=24096
    - **Original**: https://deriv-app-git-fork-thisyahlen-deriv-thisyahlen-wall-430t-c30e22.binary.sx
- **App ID**: `24096`

@github-actions
Copy link
Contributor

github-actions bot commented Apr 20, 2023

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 19
🟧 Accessibility 75
🟢 Best practices 92
🟧 SEO 85
🟢 PWA 90

Lighthouse ran with https://deriv-app-git-fork-thisyahlen-deriv-thisyahlen-wall-430t-c30e22.binary.sx/

@codecov-commenter
Copy link

codecov-commenter commented Apr 20, 2023

Codecov Report

Merging #8320 (79088ea) into master (f1faef7) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #8320      +/-   ##
==========================================
+ Coverage   19.21%   19.24%   +0.02%     
==========================================
  Files        1800     1800              
  Lines       41033    41033              
  Branches     8139     8139              
==========================================
+ Hits         7885     7896      +11     
+ Misses      32339    32327      -12     
- Partials      809      810       +1     
Impacted Files Coverage Δ
packages/stores/src/mockStore.ts 0.00% <ø> (ø)
.../components/main-title-bar/regulators-switcher.tsx 91.66% <100.00%> (+91.66%) ⬆️

farzin-deriv
farzin-deriv previously approved these changes Apr 20, 2023
hamza-deriv
hamza-deriv previously approved these changes Apr 20, 2023
matin-deriv
matin-deriv previously approved these changes Apr 20, 2023
…len/WALL-430/test_coverage_on_regulators_switcher
@boring-cyborg boring-cyborg bot added the Core label May 25, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jun 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
6.3% 6.3% Duplication

@github-actions
Copy link
Contributor

github-actions bot commented Jun 1, 2023

Generating Lighthouse report...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants