Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Farabi/fix image height on responsive #8566

Conversation

farabi-deriv
Copy link
Contributor

No description provided.

@boring-cyborg boring-cyborg bot added the Core label May 10, 2023
@vercel
Copy link

vercel bot commented May 10, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 10, 2023 5:16pm

@github-actions
Copy link
Contributor

github-actions bot commented May 10, 2023

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/8566](https://github.com/binary-com/deriv-app/pull/8566)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-farabi-deriv-farabi-fix-image-height-fc10b6.binary.sx?qa_server=red.binaryws.com&app_id=24020
    - **Original**: https://deriv-app-git-fork-farabi-deriv-farabi-fix-image-height-fc10b6.binary.sx
- **App ID**: `24020`

@github-actions
Copy link
Contributor

github-actions bot commented May 10, 2023

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 21
🟧 Accessibility 75
🟢 Best practices 92
🟧 SEO 85
🟢 PWA 90

Lighthouse ran with https://deriv-app-git-fork-farabi-deriv-farabi-fix-image-height-fc10b6.binary.sx/

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (dbot-homepage@8d5b57c). Click here to learn what that means.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@               Coverage Diff                @@
##             dbot-homepage    #8566   +/-   ##
================================================
  Coverage                 ?   19.03%           
================================================
  Files                    ?     1708           
  Lines                    ?    39770           
  Branches                 ?     7585           
================================================
  Hits                     ?     7570           
  Misses                   ?    31456           
  Partials                 ?      744           

@sonarcloud
Copy link

sonarcloud bot commented May 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sandeep-deriv sandeep-deriv merged commit bcf9f8e into deriv-com:dbot-homepage May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants