Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rupato/fix: language switcher on traders hub #8660

Conversation

rupato-deriv
Copy link
Contributor

No description provided.

@vercel
Copy link

vercel bot commented May 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 1, 2023 10:48am

@github-actions
Copy link
Contributor

github-actions bot commented May 18, 2023

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/8660](https://github.com/binary-com/deriv-app/pull/8660)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-rupato-deriv-rupato-fix-for-language-89f6f6.binary.sx?qa_server=red.binaryws.com&app_id=32805
    - **Original**: https://deriv-app-git-fork-rupato-deriv-rupato-fix-for-language-89f6f6.binary.sx
- **App ID**: `32805`

@github-actions
Copy link
Contributor

github-actions bot commented May 18, 2023

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 19
🟧 Accessibility 75
🟢 Best practices 92
🟧 SEO 85
🟢 PWA 90

Lighthouse ran with https://deriv-app-git-fork-rupato-deriv-rupato-fix-for-language-89f6f6.binary.sx/

@rupato-deriv rupato-deriv changed the title fix: language switcher on traders hub Rupato/fix: language switcher on traders hub May 22, 2023
shafin-deriv
shafin-deriv previously approved these changes May 25, 2023
@codecov-commenter
Copy link

codecov-commenter commented May 31, 2023

Codecov Report

Merging #8660 (f240f38) into master (f1faef7) will increase coverage by 0.00%.
The diff coverage is 40.00%.

❗ Current head f240f38 differs from pull request most recent head 298b852. Consider uploading reports for the commit 298b852 to get more accurate results

@@           Coverage Diff           @@
##           master    #8660   +/-   ##
=======================================
  Coverage   19.21%   19.22%           
=======================================
  Files        1800     1800           
  Lines       41033    41038    +5     
  Branches     8139     8141    +2     
=======================================
+ Hits         7885     7888    +3     
- Misses      32339    32341    +2     
  Partials      809      809           
Impacted Files Coverage Δ
...pp/Components/Layout/Header/toggle-menu-drawer.jsx 0.00% <ø> (ø)
...rc/App/Containers/Layout/header/default-header.jsx 0.00% <ø> (ø)
...rc/App/Containers/Layout/header/dtrader-header.jsx 0.00% <ø> (ø)
...re/src/Modules/BinaryBotIFrame/BinaryBotIFrame.jsx 0.00% <0.00%> (ø)
packages/core/src/Stores/client-store.js 0.00% <0.00%> (ø)
...App/Components/Layout/Header/platform-switcher.jsx 52.38% <50.00%> (+5.71%) ⬆️
packages/shared/src/utils/url/helpers.ts 64.51% <50.00%> (-3.23%) ⬇️

@sonarcloud
Copy link

sonarcloud bot commented Jun 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
3.2% 3.2% Duplication

@github-actions
Copy link
Contributor

github-actions bot commented Jun 1, 2023

Generating Lighthouse report...

@bahar-sadeghzadeh bahar-sadeghzadeh merged commit 06b2018 into deriv-com:master Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants