Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

george / WALL-739 / clickable trade platform logo, title and description in Trader's hub #8754

Conversation

heorhi-deriv
Copy link
Contributor

Changes:

Please provide a summary of the change.

Screenshots:

Please provide some screenshots of the change.

@vercel
Copy link

vercel bot commented May 25, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 26, 2023 10:08am

@github-actions
Copy link
Contributor

github-actions bot commented May 25, 2023

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/8754](https://github.com/binary-com/deriv-app/pull/8754)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-heorhi-deriv-wall-739-clickable-logo-8e351d.binary.sx?qa_server=red.binaryws.com&app_id=30366
    - **Original**: https://deriv-app-git-fork-heorhi-deriv-wall-739-clickable-logo-8e351d.binary.sx
- **App ID**: `30366`

@github-actions
Copy link
Contributor

github-actions bot commented May 25, 2023

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 21
🟧 Accessibility 75
🟢 Best practices 92
🟧 SEO 85
🟢 PWA 90

Lighthouse ran with https://deriv-app-git-fork-heorhi-deriv-wall-739-clickable-logo-8e351d.binary.sx/

@codecov-commenter
Copy link

codecov-commenter commented May 25, 2023

Codecov Report

Merging #8754 (6e9b9f0) into master (784175f) will not change coverage.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##           master    #8754   +/-   ##
=======================================
  Coverage   39.63%   39.63%           
=======================================
  Files         212      212           
  Lines        4494     4494           
  Branches     1237     1237           
=======================================
  Hits         1781     1781           
  Misses       2482     2482           
  Partials      231      231           

farzin-deriv
farzin-deriv previously approved these changes May 26, 2023
packages/appstore/src/constants/platform-config.ts Outdated Show resolved Hide resolved
aizad-deriv
aizad-deriv previously approved these changes May 26, 2023
@boring-cyborg boring-cyborg bot added the Shared label May 26, 2023
@sonarcloud
Copy link

sonarcloud bot commented May 26, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@@ -3,21 +3,25 @@ import classNames from 'classnames';
import { getStatusBadgeConfig } from '@deriv/account';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@heorhi-deriv please order the imports according to the convention followed 😄 .

@bahar-sadeghzadeh bahar-sadeghzadeh merged commit a9ed648 into deriv-com:master Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment