Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shayan/feq 275/fix reduce of empty array with no initial value #9160

Conversation

shayan-deriv
Copy link
Contributor

Changes:

added missed initial values for reduce()

@vercel
Copy link

vercel bot commented Jun 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 10, 2023 9:22am

@github-actions
Copy link
Contributor

github-actions bot commented Jun 27, 2023

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/9160](https://github.com/binary-com/deriv-app/pull/9160)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-shayan-deriv-shayan-feq-275fix-reduce-50573b.binary.sx?qa_server=red.binaryws.com&app_id=31476
    - **Original**: https://deriv-app-git-fork-shayan-deriv-shayan-feq-275fix-reduce-50573b.binary.sx
- **App ID**: `31476`

@github-actions
Copy link
Contributor

github-actions bot commented Jun 27, 2023

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 19
🟧 Accessibility 75
🟢 Best practices 92
🟧 SEO 85
🟢 PWA 90

Lighthouse ran with https://deriv-app-git-fork-shayan-deriv-shayan-feq-275fix-reduce-50573b.binary.sx/

@shayan-deriv
Copy link
Contributor Author

I'm fixing the circleci issue

@ali-hosseini-deriv
Copy link
Member

@shayan-deriv as i checked with @rupato-deriv it seems that we will have a problem with your changes on bot-skeleton
Please check it with him to make sure that it's safe to use

@shayan-deriv
Copy link
Contributor Author

@shayan-deriv as i checked with @rupato-deriv it seems that we will have a problem with your changes on bot-skeleton Please check it with him to make sure that it's safe to use

Yes. I will check with him today

@shayan-deriv
Copy link
Contributor Author

@shayan-deriv as i checked with @rupato-deriv it seems that we will have a problem with your changes on bot-skeleton Please check it with him to make sure that it's safe to use

Yes. I will check with him today

@ali-hosseini-deriv just an UPDATE! I excluded one change from this PR since it was breaking DBot . we decided to have a separate card for it and pass it to bot team.
and for the relative-strength-index I'm checking it with @balakrishna-deriv .

@coveralls
Copy link

coveralls commented Jul 4, 2023

Coverage Status

coverage: 8.913%. remained the same when pulling d1a0f87 on shayan-deriv:shayan/feq-275/fix-reduce-of-empty-array-with-no-initial-value into ea9f6cb on binary-com:master.

@sonarcloud
Copy link

sonarcloud bot commented Jul 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link
Contributor

Generating Lighthouse report...

@ali-hosseini-deriv ali-hosseini-deriv merged commit ef2806a into deriv-com:master Jul 10, 2023
@ali-hosseini-deriv
Copy link
Member

✨ PR has been merged by Paimon the Release Bot

@shayan-deriv shayan-deriv deleted the shayan/feq-275/fix-reduce-of-empty-array-with-no-initial-value branch January 12, 2024 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants