Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ako / FEQ 400/ Fix ci failings #9190

Conversation

ali-hosseini-deriv
Copy link
Member

Changes:

  • Added override config for the proptypes on ts
  • Set the Max worker for jest to 6
  • Build accounts package before the rest to fix the build problem on CI

Screenshots:

Please provide some screenshots of the change.

@vercel
Copy link

vercel bot commented Jun 30, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 30, 2023 11:38am

@sonarcloud
Copy link

sonarcloud bot commented Jun 30, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
3.6% 3.6% Duplication

@github-actions
Copy link
Contributor

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/9190](https://github.com/binary-com/deriv-app/pull/9190)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-ali-hosseini-deriv-ako-feq-400fix-ci-bb2843.binary.sx?qa_server=red.binaryws.com&app_id=24160
    - **Original**: https://deriv-app-git-fork-ali-hosseini-deriv-ako-feq-400fix-ci-bb2843.binary.sx
- **App ID**: `24160`

@github-actions
Copy link
Contributor

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 20
🟧 Accessibility 75
🟢 Best practices 92
🟧 SEO 85
🟢 PWA 90

Lighthouse ran with https://deriv-app-git-fork-ali-hosseini-deriv-ako-feq-400fix-ci-bb2843.binary.sx/

@@ -68,7 +68,7 @@
"ts-jest": "^26.4.2"
},
"scripts": {
"build:all": "nx build @deriv/components --skip-nx-cache && nx run-many --target=build",
"build:all": "nx build @deriv/components --skip-nx-cache && nx build @deriv/account --skip-nx-cache && nx run-many --target=build",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this all the time or can we remove it after the build?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all of the builds should happen in this order.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I remember the build process was killed for other packages as well and not just the account. But we can test this out to see if it works.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

running the circleci runner to see if it's working or not

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ali-hosseini-deriv ali-hosseini-deriv merged commit 38d6f42 into deriv-com:master Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants