Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Farzin/WEBREL-1103/Not displaying Recent Transactions table on clicking view all button #9760

Merged
merged 1 commit into from
Aug 21, 2023
Merged

Farzin/WEBREL-1103/Not displaying Recent Transactions table on clicking view all button #9760

merged 1 commit into from
Aug 21, 2023

Conversation

farzin-deriv
Copy link
Contributor

Changes:

Please provide a summary of the change.

Screenshots:

Please provide some screenshots of the change.

@vercel
Copy link

vercel bot commented Aug 19, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Aug 19, 2023 4:51am

farzin-deriv
farzin-deriv commented Aug 19, 2023
View reviewed changes
packages/cashier/src/pages/withdrawal/withdrawal.tsx
@@ -139,6 +143,8 @@ const Withdrawal = observer(({ setSideNotes }: TWithdrawalProps) => {
return <WithdrawalLocked />;
}

if (is_crypto_transactions_visible) return <CryptoTransactionsHistory />;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lift up the is_crypto_transactions_visible condition to have higher priority.

packages/cashier/src/pages/withdrawal/withdrawal.tsx
Comment on lines +103 to +105
if (is_crypto_transactions_visible) {
setSideNotes?.([]);
} else {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clear the side notes when the <CryptoTransactionsHistory /> is visible.

packages/cashier/src/pages/account-transfer/account-transfer.tsx
Comment on lines -94 to -96
if (!is_from_outside_cashier && is_crypto_transactions_visible) {
return <CryptoTransactionsHistory />;
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We never render the CryptoTransactionsHistory /> inside the <AccountTransfer /> page, hence removing it.

@sonarcloud
Copy link

sonarcloud bot commented Aug 19, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link
Contributor

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information. 
- **PR**: [https://github.com/binary-com/deriv-app/pull/9760](https://github.com/binary-com/deriv-app/pull/9760)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-farzin-deriv-farzin-webrel-1103notdis-825b5e.binary.sx?qa_server=red.binaryws.com&app_id=23835
    - **Original**: https://deriv-app-git-fork-farzin-deriv-farzin-webrel-1103notdis-825b5e.binary.sx
- **App ID**: `23835`

@github-actions
Copy link
Contributor

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 17
🟧 Accessibility 75
🟢 Best practices 92
🟧 SEO 85
🟢 PWA 90

Lighthouse ran with https://deriv-app-git-fork-farzin-deriv-farzin-webrel-1103notdis-825b5e.binary.sx/

@coveralls
Copy link

Coverage Status

coverage: 10.134% (-0.001%) from 10.135% when pulling c140565 on farzin-deriv:farzin/WEBREL-1103/not_displaying_recent_transactions_table_on_clicking_view_all_button into 6ad6607 on binary-com:master.

@farzin-deriv farzin-deriv marked this pull request as ready for review August 19, 2023 05:12
niloofar-deriv
niloofar-deriv approved these changes Aug 20, 2023
View reviewed changes
Copy link
Contributor

@niloofar-deriv niloofar-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jim-deriv jim-deriv merged commit 09733d0 into deriv-com:master Aug 21, 2023
4 checks passed
@farzin-deriv farzin-deriv deleted the farzin/WEBREL-1103/not_displaying_recent_transactions_table_on_clicking_view_all_button branch August 21, 2023 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niloofar-deriv niloofar-deriv niloofar-deriv approved these changes

@farrah-deriv farrah-deriv farrah-deriv approved these changes

@nijil-deriv nijil-deriv Awaiting requested review from nijil-deriv nijil-deriv is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@farzin-deriv @coveralls @farrah-deriv @niloofar-deriv @jim-deriv