Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cashier): 🐛 fix fiat withdrawal issue on mobile #9798

Merged
merged 7 commits into from
Aug 24, 2023

Conversation

farzin-deriv
Copy link
Contributor

Changes:

Please provide a summary of the change.

Screenshots:

Please provide some screenshots of the change.

@vercel
Copy link

vercel bot commented Aug 23, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Aug 24, 2023 9:19am

@github-actions
Copy link
Contributor

github-actions bot commented Aug 23, 2023

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/9798](https://github.com/binary-com/deriv-app/pull/9798)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-farzin-deriv-farzin-fix.binary.sx?qa_server=red.binaryws.com&app_id=24088
    - **Original**: https://deriv-app-git-fork-farzin-deriv-farzin-fix.binary.sx
- **App ID**: `24088`

@github-actions
Copy link
Contributor

github-actions bot commented Aug 23, 2023

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 21
🟧 Accessibility 75
🟢 Best practices 92
🟧 SEO 85
🟢 PWA 90

Lighthouse ran with https://deriv-app-git-fork-farzin-deriv-farzin-fix.binary.sx/

@farzin-deriv farzin-deriv changed the title fix(cashier): 🐛 fix fix(cashier): 🐛 fix fiat withdrawal issue on mobile Aug 23, 2023
@coveralls
Copy link

coveralls commented Aug 23, 2023

Coverage Status

coverage: 10.052% (+0.003%) from 10.049% when pulling 2dfbdfa on farzin-deriv:farzin/fix into f6556e7 on binary-com:master.

@farzin-deriv farzin-deriv marked this pull request as ready for review August 23, 2023 08:53
nijil-deriv
nijil-deriv previously approved these changes Aug 23, 2023
Comment on lines +169 to +171
useEffect(() => {
updateActiveTab(selected_route.path);
}, [selected_route, updateActiveTab]);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the active_container on mobile when the selected_route changes.

@sonarcloud
Copy link

sonarcloud bot commented Aug 24, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@nijil-deriv nijil-deriv merged commit e0e8a53 into deriv-com:master Aug 24, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants