Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use of reserved word as variable name #11

Open
retrogradeorbit opened this issue Jul 22, 2017 · 0 comments
Open

use of reserved word as variable name #11

retrogradeorbit opened this issue Jul 22, 2017 · 0 comments

Comments

@retrogradeorbit
Copy link

retrogradeorbit commented Jul 22, 2017

The use of the variable name 'byte' causes google closure compiler to refuse to compile the source.

Google closure compiler exits with:

ERROR: JSC_PARSE_ERROR. Parse error. identifier is a reserved word at ./node_modules/js-binarypack/lib/binarypack.js line 111 : 6
ERROR: JSC_PARSE_ERROR. Parse error. identifier is a reserved word at ./node_modules/js-binarypack/lib/binarypack.js line 113 : 9

Attached a PR removing the use of a temporary variable entirely. #12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant