Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unblocked TODO: /rust-lang/rust/issues/73179 was closed. #416

Closed
blockedtodo bot opened this issue Oct 24, 2021 · 4 comments · Fixed by #473
Closed

Unblocked TODO: /rust-lang/rust/issues/73179 was closed. #416

blockedtodo bot opened this issue Oct 24, 2021 · 4 comments · Fixed by #473

Comments

@blockedtodo
Copy link

blockedtodo bot commented Oct 24, 2021

Link to closed issue: rust-lang/rust#73179

This issue was automatically triggered by the following comment in src/features/impl_std.rs.

// BlockedTODO: https://github.com/rust-lang/rust/issues/73179
        // use `from_vec_with_nul` instead, combined with:
        // let bytes = std::vec::Vec::<u8>::decode(decoder)?;
@VictorKoenders
Copy link
Contributor

As per rust-lang/rust#89292 (comment)

rustbot added this to the 1.58.0 milestone

So I guess for this we'll want to wait until 1.58

@VictorKoenders
Copy link
Contributor

Rust 1.58 should be released on Jan 13th

@qarmin
Copy link

qarmin commented Dec 28, 2021

So MSRV will be at least 1.58 for bincode 2.0 or maybe this will be changed in 2.x versions?

@VictorKoenders
Copy link
Contributor

We'll pick a version of rust we want to support when bincode 2.0 is released properly, and support that version throughout the 2.x lifetime (although we might add features to bump the MSRV if useful features come out)

1.58 seems to be a solid contender for this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants