Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_OpenApiItemsArray and _OpenApiItemsObject should be Prisms, not Reviews #72

Open
gelisam opened this issue Dec 16, 2022 · 0 comments
Open

Comments

@gelisam
Copy link

gelisam commented Dec 16, 2022

The OpenApiItems prisms section defines Reviews, not Prisms. I assume that's a mistake? A Prism is a Review but not the other way around, so this is needlessly limiting.

In the history of the file, I see that Prisms used to be generated using makePrisms, but in cd3dc81 the makePrisms was replaced with a manual prism definition... with a Review type signature. The commit message says "fix build by manually writing out SwaggerItems prisms", so it does not seem like the restriction to Review was intentional.

Later on, in 68e95a6, the prism implementation was changed to an unto, which does produce a Review, but the second direction of the prism implementation was kept in a comment. The commit message says "Make compile cleanly with stack --pedantic", so it again does not seem like the restriction to Review was intentional.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant