-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update tower-cli version to v0.10.3 #51480
Conversation
📝 Walkthrough📝 WalkthroughWalkthroughThis pull request modifies the Additionally, the shell script Possibly related PRs
Suggested labels
Suggested reviewers
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🧰 Additional context used🔇 Additional comments (2)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
recipes/tower-cli/meta.yaml (1)
14-14
: Remove trailing spacesThe static analysis tool detected trailing spaces on this line. While this doesn't affect functionality, it's good practice to remove them for code cleanliness.
Please remove the trailing spaces from this line.
🧰 Tools
🪛 yamllint
[error] 14-14: trailing spaces
(trailing-spaces)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
- recipes/tower-cli/meta.yaml (1 hunks)
🧰 Additional context used
🪛 yamllint
recipes/tower-cli/meta.yaml
[error] 14-14: trailing spaces
(trailing-spaces)
🔇 Additional comments (4)
recipes/tower-cli/meta.yaml (4)
2-2
: LGTM: Version update to 0.10.3The version update from 0.9.2 to 0.10.3 aligns with the PR objective. This minor version bump likely includes new features or bug fixes.
10-10
: LGTM: Build number resetResetting the build number to 0 is the correct approach when updating to a new version. This change is consistent with the version update.
16-16
: Verify the source URL and file nameThe source URL has been updated to use 'tw-jar.jar' instead of 'tw.jar'. Please confirm that this change is consistent with the actual file name in the tower-cli repository for version 0.10.3.
Run the following script to verify the existence and name of the JAR file:
✅ Verification successful
Source URL and file name verified
The file
tw-jar.jar
exists at the specified URL. The update inmeta.yaml
is correct.🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the existence and name of the JAR file url="https://github.com/seqeralabs/tower-cli/releases/download/v0.10.3/tw-jar.jar" # Check if the file exists if curl --output /dev/null --silent --head --fail "$url"; then echo "File exists: $url" else echo "File does not exist: $url" echo "Checking for alternative file names..." # Check for tw.jar (old name) alt_url="${url/tw-jar.jar/tw.jar}" if curl --output /dev/null --silent --head --fail "$alt_url"; then echo "Found alternative file: $alt_url" echo "Consider updating the URL in meta.yaml to use 'tw.jar' instead of 'tw-jar.jar'" else echo "Alternative file not found: $alt_url" fi fiLength of output: 397
3-3
: Verify the SHA256 checksumThe SHA256 checksum has been updated as expected for the new version. To ensure the integrity and security of the package, please verify that this checksum is correct for the new version of tower-cli.
Run the following script to verify the SHA256 checksum:
Describe your pull request here
Please read the guidelines for Bioconda recipes before opening a pull request (PR).
General instructions
@BiocondaBot please add label
command.@bioconda/core
in a comment.Instructions for avoiding API, ABI, and CLI breakage issues
Conda is able to record and lock (a.k.a. pin) dependency versions used at build time of other recipes.
This way, one can avoid that expectations of a downstream recipe with regards to API, ABI, or CLI are violated by later changes in the recipe.
If not already present in the meta.yaml, make sure to specify
run_exports
(see here for the rationale and comprehensive explanation).Add a
run_exports
section like this:with
...
being one of:{{ pin_subpackage("myrecipe", max_pin="x") }}
{{ pin_subpackage("myrecipe", max_pin="x.x") }}
{{ pin_subpackage("myrecipe", max_pin="x.x") }}
(in such a case, please add a note that shortly mentions your evidence for that){{ pin_subpackage("myrecipe", max_pin="x.x.x") }}
(in such a case, please add a note that shortly mentions your evidence for that){{ pin_subpackage("myrecipe", max_pin=None) }}
while replacing
"myrecipe"
with eithername
if aname|lower
variable is defined in your recipe or with the lowercase name of the package in quotes.Bot commands for PR management
Please use the following BiocondaBot commands:
Everyone has access to the following BiocondaBot commands, which can be given in a comment:
@BiocondaBot please update
@BiocondaBot please add label
please review & merge
label.@BiocondaBot please fetch artifacts
You can use this to test packages locally.
Note that the
@BiocondaBot please merge
command is now depreciated. Please just squash and merge instead.Also, the bot watches for comments from non-members that include
@bioconda/<team>
and will automatically re-post them to notify the addressed<team>
.