Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tower-cli version to v0.10.3 #51480

Merged
merged 4 commits into from
Oct 21, 2024
Merged

Update tower-cli version to v0.10.3 #51480

merged 4 commits into from
Oct 21, 2024

Conversation

adamrtalbot
Copy link
Contributor

Describe your pull request here


Please read the guidelines for Bioconda recipes before opening a pull request (PR).

General instructions

  • If this PR adds or updates a recipe, use "Add" or "Update" appropriately as the first word in its title.
  • New recipes not directly relevant to the biological sciences need to be submitted to the conda-forge channel instead of Bioconda.
  • PRs require reviews prior to being merged. Once your PR is passing tests and ready to be merged, please issue the @BiocondaBot please add label command.
  • Please post questions on Gitter or ping @bioconda/core in a comment.

Instructions for avoiding API, ABI, and CLI breakage issues

Conda is able to record and lock (a.k.a. pin) dependency versions used at build time of other recipes.
This way, one can avoid that expectations of a downstream recipe with regards to API, ABI, or CLI are violated by later changes in the recipe.
If not already present in the meta.yaml, make sure to specify run_exports (see here for the rationale and comprehensive explanation).
Add a run_exports section like this:

build:
  run_exports:
    - ...

with ... being one of:

Case run_exports statement
semantic versioning {{ pin_subpackage("myrecipe", max_pin="x") }}
semantic versioning (0.x.x) {{ pin_subpackage("myrecipe", max_pin="x.x") }}
known breakage in minor versions {{ pin_subpackage("myrecipe", max_pin="x.x") }} (in such a case, please add a note that shortly mentions your evidence for that)
known breakage in patch versions {{ pin_subpackage("myrecipe", max_pin="x.x.x") }} (in such a case, please add a note that shortly mentions your evidence for that)
calendar versioning {{ pin_subpackage("myrecipe", max_pin=None) }}

while replacing "myrecipe" with either name if a name|lower variable is defined in your recipe or with the lowercase name of the package in quotes.

Bot commands for PR management

Please use the following BiocondaBot commands:

Everyone has access to the following BiocondaBot commands, which can be given in a comment:

@BiocondaBot please update Merge the master branch into a PR.
@BiocondaBot please add label Add the please review & merge label.
@BiocondaBot please fetch artifacts Post links to CI-built packages/containers.
You can use this to test packages locally.

Note that the @BiocondaBot please merge command is now depreciated. Please just squash and merge instead.

Also, the bot watches for comments from non-members that include @bioconda/<team> and will automatically re-post them to notify the addressed <team>.

Copy link
Contributor

coderabbitai bot commented Oct 18, 2024

📝 Walkthrough
📝 Walkthrough

Walkthrough

This pull request modifies the meta.yaml file for the tower-cli package. The key changes include updating the version number from 0.9.2 to 0.10.3, changing the SHA256 checksum from c9ebabdfe7aaeea0ce823c39819b0091503e6e8bf751281f90b620d20d365cec to fe2aa1fe127196a33527f075ab23526a7fb98c00b152fa6adf32ccbc1802f2cb, and modifying the build number from 1 to 0. The source URL is also updated to reflect the new version, linking to tw-jar.jar for version 0.10.3. All other components of the meta.yaml file, such as package metadata, requirements, test commands, and additional information, remain unchanged.

Additionally, the shell script tw.sh is updated to change the name of the JAR file being executed from "tw.jar" to "tw-jar.jar". This change ensures that the script correctly references the new JAR file name while maintaining the overall logic and error handling mechanisms of the script.

Possibly related PRs

  • Update snk-cli to 0.5.4 #51233: The snk-cli package update involves changing the version and SHA256 checksum in the meta.yaml file, similar to the changes made in the tower-cli package in the main PR.
  • Update vcf-validator to v0.10.0 #51421: The vcf-validator package update also includes a version increment and SHA256 checksum update in its meta.yaml, paralleling the changes in the main PR for tower-cli.

Suggested labels

autobump, new version

Suggested reviewers

  • martin-g

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between b71cac8 and 5ebe1f3.

📒 Files selected for processing (1)
  • recipes/tower-cli/tw.sh (2 hunks)
🧰 Additional context used
🔇 Additional comments (2)
recipes/tower-cli/tw.sh (2)

Line range hint 1-64: Overall script structure and functionality look good.

The script is well-written, with proper error handling, good comments, and correct handling of Java options and arguments. No additional changes are needed due to the JAR file name update.


7-7: LGTM! Jar file name updated correctly.

The change from tw.jar to tw-jar.jar is consistent with the package update to version 0.10.3 mentioned in the PR objectives.

Let's verify if this change is consistent across all relevant files:


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)
recipes/tower-cli/meta.yaml (1)

14-14: Remove trailing spaces

The static analysis tool detected trailing spaces on this line. While this doesn't affect functionality, it's good practice to remove them for code cleanliness.

Please remove the trailing spaces from this line.

🧰 Tools
🪛 yamllint

[error] 14-14: trailing spaces

(trailing-spaces)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 92540ea and b71cac8.

📒 Files selected for processing (1)
  • recipes/tower-cli/meta.yaml (1 hunks)
🧰 Additional context used
🪛 yamllint
recipes/tower-cli/meta.yaml

[error] 14-14: trailing spaces

(trailing-spaces)

🔇 Additional comments (4)
recipes/tower-cli/meta.yaml (4)

2-2: LGTM: Version update to 0.10.3

The version update from 0.9.2 to 0.10.3 aligns with the PR objective. This minor version bump likely includes new features or bug fixes.


10-10: LGTM: Build number reset

Resetting the build number to 0 is the correct approach when updating to a new version. This change is consistent with the version update.


16-16: Verify the source URL and file name

The source URL has been updated to use 'tw-jar.jar' instead of 'tw.jar'. Please confirm that this change is consistent with the actual file name in the tower-cli repository for version 0.10.3.

Run the following script to verify the existence and name of the JAR file:

✅ Verification successful

Source URL and file name verified

The file tw-jar.jar exists at the specified URL. The update in meta.yaml is correct.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the existence and name of the JAR file

url="https://github.com/seqeralabs/tower-cli/releases/download/v0.10.3/tw-jar.jar"

# Check if the file exists
if curl --output /dev/null --silent --head --fail "$url"; then
    echo "File exists: $url"
else
    echo "File does not exist: $url"
    echo "Checking for alternative file names..."
    
    # Check for tw.jar (old name)
    alt_url="${url/tw-jar.jar/tw.jar}"
    if curl --output /dev/null --silent --head --fail "$alt_url"; then
        echo "Found alternative file: $alt_url"
        echo "Consider updating the URL in meta.yaml to use 'tw.jar' instead of 'tw-jar.jar'"
    else
        echo "Alternative file not found: $alt_url"
    fi
fi

Length of output: 397


3-3: Verify the SHA256 checksum

The SHA256 checksum has been updated as expected for the new version. To ensure the integrity and security of the package, please verify that this checksum is correct for the new version of tower-cli.

Run the following script to verify the SHA256 checksum:

@adamrtalbot adamrtalbot merged commit 5d41cac into master Oct 21, 2024
7 checks passed
@adamrtalbot adamrtalbot deleted the tower-cli-v0.10.3 branch October 21, 2024 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants