Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: lint missing run exports #908

Merged
merged 11 commits into from
Aug 24, 2023
Merged

Conversation

johanneskoester
Copy link
Contributor

No description provided.

@johanneskoester
Copy link
Contributor Author

Comment by @mbargull:

What shall we do in case of non-standard versioning, e.g. calendar versioning?

@johanneskoester
Copy link
Contributor Author

Shall we exclude calendar versioning from the lint?

@johanneskoester
Copy link
Contributor Author

No constraint for max_pin in such a case?

Co-authored-by: Christian Brueffer <christian@brueffer.io>
@johanneskoester
Copy link
Contributor Author

No constraint for max_pin in such a case?

Decided in our meeting, and now reflected in the lint documentation.

Copy link
Member

@bgruening bgruening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@johanneskoester johanneskoester merged commit 84f5c0c into master Aug 24, 2023
9 checks passed
@johanneskoester johanneskoester deleted the feat/lint-missing-run-exports branch August 24, 2023 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants