-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Could not find GIT using the following names: git #131
Comments
The call stack indicates the reason: to be able to use the proper version tags in the installed bin. Maybe this could be set up differently, but this is legitimate behavior. Further, if you configure with |
How would git determine what "the proper version tags" are? I am not building in a git clone. And I am not configuring with |
Well, ATM git is required to This is a reasonable expectation when cmake is being run - means it's a developer (edit: or a development image) running it, and the likelihood of having git in that situation is really high. In other words, AFAICT the case of trying to build from the downloaded tarball is rare and special enough that I deem looking at this a bad usage of my limited time. If you have the need to address this situation and installing git is not a possibility, your PR addressing the problem is very welcome: the logic is all in the cmake function |
Also, I'm curious: why is it that you can't just install git? |
When
git
is not installed, this error occurs when runningcmake
:Why would a library of low-level C++ utilities need
git
to be installed?If
git
is only used at build time, I have not cloned your repository; I have downloaded the release tarball from https://github.com/biojppm/c4core/releases/tag/v0.1.11 so there is no information thatgit
would be able to derive from the source directory.The text was updated successfully, but these errors were encountered: