-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARM_ARCH_8A #94
Comments
ATM I'm working with c4core on an armv8a 64bit platform and c4core definitely works there. I guess yours is 32bit? Looking at what cpu.hpp does: #if defined(__aarch64__) || defined(_M_ARM64)
#define C4_CPU_ARM64
#define C4_CPU_ARMV8
#define C4_WORDSIZE 8
#else
#define C4_CPU_ARM
#define C4_WORDSIZE 4
#if defined(__ARM_ARCH_8__) || (defined(__TARGET_ARCH_ARM) && __TARGET_ARCH_ARM >= 8)
#define C4_CPU_ARMV8
//... What happens if you add |
Right now, I'm
Its a toolchain, build with crosstool-ng for raspberrypi4. What toolchain are you using and what is it's output of definitions? Definitely adding |
On my side, I wrote this block of code many years ago and don't recall exactly why ARM_ARCH_8 is there. But from a quick search, there is a mention to ARM_ARCH_8 in here, so it is not widely off the mark. OTOH, on the same search I noticed this has only ARM64_ARCH_8. And no reference either in this. Also, from the dump you provide, I notice the existing check So I'll submit a fix with both. I think it makes sense. |
Thanks! 💯 |
Hi,
when I'm trying to cross-compile rapidyaml with an armv8 compiler, it does
#define __ARM_ARCH_8A__ 1
and not#define __ARM_ARCH_8__ 1
.The cpu.hpp in this library only checks for ARM_ARCH_8, which is not set in my case and hence it breaks. I'm not sure if this is just a typo here or if ARM_ARCH_8 really exists, but looking at openssl (https://github.com/openssl/openssl/blob/master/crypto/arm_arch.h) it also only checks for ARM_ARCH_8A.
The text was updated successfully, but these errors were encountered: