Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PCA: retain all data (Unification of embedding methods ) #3801

Closed
mstrazar opened this issue May 15, 2019 · 0 comments · Fixed by #4255
Closed

PCA: retain all data (Unification of embedding methods ) #3801

mstrazar opened this issue May 15, 2019 · 0 comments · Fixed by #4255
Assignees

Comments

@mstrazar
Copy link
Contributor

mstrazar commented May 15, 2019

Issue: PCA discards the original attributes and replaces them with PCs. Often (e.g. in scOrange), it is desirable to use the original features: annotate PCA plots, compute differentially-occurring features in different PCA regions, etc.

Proposed solution: Place PCs in meta attributes and rename output to Data.

This would be consistent to t-SNE and MDS. The user could use Select columns to restore current behaviour. This is substantially easier (number of PCs is typically small) than merging original attributes with principal components, as it's possible in the current version.

Such an improvement would also play nice with the new widget Apply domain, which enables projecting data to existing PCs and/or attributes.

@mstrazar mstrazar added the needs discussion Core developers need to discuss the issue label May 15, 2019
@janezd janezd removed the needs discussion Core developers need to discuss the issue label May 24, 2019
@janezd janezd added the needs discussion Core developers need to discuss the issue label Oct 11, 2019
@janezd janezd added snack This will take an hour or two and removed needs discussion Core developers need to discuss the issue labels Dec 5, 2019
@janezd janezd self-assigned this Dec 6, 2019
@janezd janezd removed the snack This will take an hour or two label Dec 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants