Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data Table: single tab, bug fixes and subset input #6315

Closed
4 tasks
janezd opened this issue Jan 25, 2023 · 2 comments · Fixed by #6405
Closed
4 tasks

Data Table: single tab, bug fixes and subset input #6315

janezd opened this issue Jan 25, 2023 · 2 comments · Fixed by #6405
Assignees

Comments

@janezd
Copy link
Contributor

janezd commented Jan 25, 2023

Changing Data Table to single input will require refactoring settings, so this change can do several things at once (not doing so would require changing code that would be later thrown away):

@janezd
Copy link
Contributor Author

janezd commented Jan 26, 2023

Now what will happen to the selection and the sorting when the input data changes? I hope that if the selection was
set to "all", still all the data remains selected and the sorting order remains.

@wvdvegte, if nothing is selected, it has the same effect as if everything is selected.

... except that in this case sorting is not reflected in the output. Fixing this efficiently will require solving #5720, which looks simple but hides some nasty details.

@janezd
Copy link
Contributor Author

janezd commented Feb 3, 2023

Note: @ales-erjavec proposed to keep the existing widget but have it in a hidden category, so old workflows will keep working. For new workflows, only the new widget would be available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants