Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📎 Implement json.parser.allowTrailingCommas #129

Closed
Conaclos opened this issue Sep 3, 2023 · 1 comment · Fixed by #326
Closed

📎 Implement json.parser.allowTrailingCommas #129

Conaclos opened this issue Sep 3, 2023 · 1 comment · Fixed by #326
Assignees
Labels
A-Parser Area: parser A-Project Area: project L-JSON Language: JSON and super languages S-Help-wanted Status: you're familiar with the code base and want to help the project

Comments

@Conaclos
Copy link
Member

Conaclos commented Sep 3, 2023

Description

As reported in #83, some config files support trailing comma.
json.parser.allowTrailingCommas: true enables trailing commas in json and jsonc files, making the following example valid:

{
  "prop1": [
    1,
    2,
  ],
  "prop2": 0,
}

Similar to json.parser.allowComments, json.parser.allowTrailingCommas: true should be enabled by default when parsing files such as tsconfig.json, VSCode config files, and others?

@Conaclos Conaclos changed the title 📎 Implememnt json.parser.allowTrailingComma 📎 Implement json.parser.allowTrailingComma Sep 3, 2023
@Conaclos Conaclos added L-JSON Language: JSON and super languages S-Help-wanted Status: you're familiar with the code base and want to help the project labels Sep 3, 2023
@Conaclos Conaclos changed the title 📎 Implement json.parser.allowTrailingComma 📎 Implement json.parser.allowTrailingCommas Sep 3, 2023
@nissy-dev nissy-dev self-assigned this Sep 18, 2023
@nissy-dev
Copy link
Contributor

I'm working

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Parser Area: parser A-Project Area: project L-JSON Language: JSON and super languages S-Help-wanted Status: you're familiar with the code base and want to help the project
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants