Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💅 Linting not working in GHA, fine locally #2856

Closed
1 task done
wadehammes opened this issue May 14, 2024 · 2 comments
Closed
1 task done

💅 Linting not working in GHA, fine locally #2856

wadehammes opened this issue May 14, 2024 · 2 comments

Comments

@wadehammes
Copy link

Environment information

CLI:
  Version:                      1.7.3
  Color support:                true

Platform:
  CPU Architecture:             aarch64
  OS:                           macos

Environment:
  BIOME_LOG_DIR:                unset
  NO_COLOR:                     unset
  TERM:                         "xterm-256color"
  JS_RUNTIME_VERSION:           "v20.13.1"
  JS_RUNTIME_NAME:              "node"
  NODE_PACKAGE_MANAGER:         "pnpm/9.1.1"

Biome Configuration:
  Status:                       Loaded successfully
  Formatter disabled:           false
  Linter disabled:              false
  Organize imports disabled:    false
  VCS disabled:                 false

Linter:
  Recommended:                  false
  All:                          false
  Rules:                        a11y/noAccessKey = "error"
                                a11y/noAriaUnsupportedElements = "error"
                                a11y/noAutofocus = "error"
                                a11y/noBlankTarget = "error"
                                a11y/noDistractingElements = "error"
                                a11y/noHeaderScope = "error"
                                a11y/noInteractiveElementToNoninteractiveRole = "error"
                                a11y/noNoninteractiveElementToInteractiveRole = "error"
                                a11y/noNoninteractiveTabindex = "error"
                                a11y/noPositiveTabindex = "error"
                                a11y/noRedundantAlt = "error"
                                a11y/noRedundantRoles = "error"
                                a11y/useAltText = "error"
                                a11y/useAnchorContent = "error"
                                a11y/useAriaActivedescendantWithTabindex = "error"
                                a11y/useAriaPropsForRole = "error"
                                a11y/useHeadingContent = "error"
                                a11y/useHtmlLang = "error"
                                a11y/useIframeTitle = "error"
                                a11y/useKeyWithClickEvents = "error"
                                a11y/useKeyWithMouseEvents = "error"
                                a11y/useMediaCaption = "error"
                                a11y/useValidAnchor = "error"
                                a11y/useValidAriaProps = "error"
                                a11y/useValidAriaRole = "error"
                                a11y/useValidAriaValues = "error"
                                complexity/noBannedTypes = "error"
                                complexity/noExtraBooleanCast = "error"
                                complexity/noMultipleSpacesInRegularExpressionLiterals = "error"
                                complexity/noUselessCatch = "error"
                                complexity/noUselessConstructor = "error"
                                complexity/noUselessFragments = "error"
                                complexity/noUselessLabel = "error"
                                complexity/noUselessLoneBlockStatements = "error"
                                complexity/noUselessRename = "error"
                                complexity/noUselessThisAlias = "error"
                                complexity/noUselessTypeConstraint = "error"
                                complexity/noWith = "error"
                                complexity/useLiteralKeys = "error"
                                correctness/noConstAssign = "error"
                                correctness/noConstantCondition = "error"
                                correctness/noEmptyCharacterClassInRegex = "error"
                                correctness/noEmptyPattern = "error"
                                correctness/noGlobalObjectCalls = "error"
                                correctness/noInnerDeclarations = "error"
                                correctness/noInvalidConstructorSuper = "error"
                                correctness/noInvalidUseBeforeDeclaration = "error"
                                correctness/noNewSymbol = "error"
                                correctness/noNonoctalDecimalEscape = "error"
                                correctness/noPrecisionLoss = "error"
                                correctness/noSelfAssign = "error"
                                correctness/noSetterReturn = "error"
                                correctness/noSwitchDeclarations = "error"
                                correctness/noUndeclaredVariables = "off"
                                correctness/noUnreachable = "error"
                                correctness/noUnreachableSuper = "error"
                                correctness/noUnsafeFinally = "error"
                                correctness/noUnsafeOptionalChaining = "error"
                                correctness/noUnusedLabels = "error"
                                correctness/noUnusedVariables = "error"
                                correctness/useExhaustiveDependencies = "error"
                                correctness/useHookAtTopLevel = "error"
                                correctness/useIsNan = "error"
                                correctness/useValidForDirection = "error"
                                correctness/useYield = "error"
                                security/noDangerouslySetInnerHtml = "error"
                                security/noGlobalEval = "error"
                                style/noCommaOperator = "error"
                                style/noDefaultExport = "off"
                                style/noInferrableTypes = "off"
                                style/noNamespace = "error"
                                style/noNonNullAssertion = "error"
                                style/noRestrictedGlobals = {"level":"error","options":{"deniedGlobals":["addEventListener","blur","close","closed","confirm","defaultStatus","defaultstatus","event","external","find","focus","frameElement","frames","history","innerHeight","innerWidth","length","location","locationbar","menubar","moveBy","moveTo","name","onblur","onerror","onfocus","onload","onresize","onunload","open","opener","opera","outerHeight","outerWidth","pageXOffset","pageYOffset","parent","print","removeEventListener","resizeBy","resizeTo","screen","screenLeft","screenTop","screenX","screenY","scroll","scrollbars","scrollBy","scrollTo","scrollX","scrollY","self","status","statusbar","stop","toolbar","top"]}}
                                style/noUselessElse = "off"
                                style/useAsConstAssertion = "error"
                                style/useBlockStatements = "error"
                                style/useDefaultParameterLast = "error"
                                style/useNamingConvention = {"level":"error","options":{"strictCase":false}}
                                suspicious/noAssignInExpressions = "error"
                                suspicious/noAsyncPromiseExecutor = "error"
                                suspicious/noCatchAssign = "error"
                                suspicious/noClassAssign = "error"
                                suspicious/noCommentText = "error"
                                suspicious/noCompareNegZero = "error"
                                suspicious/noConfusingLabels = "error"
                                suspicious/noConsoleLog = "error"
                                suspicious/noControlCharactersInRegex = "error"
                                suspicious/noDebugger = "error"
                                suspicious/noDoubleEquals = "error"
                                suspicious/noDuplicateCase = "error"
                                suspicious/noDuplicateClassMembers = "error"
                                suspicious/noDuplicateJsxProps = "error"
                                suspicious/noDuplicateObjectKeys = "error"
                                suspicious/noDuplicateParameters = "error"
                                suspicious/noEmptyBlockStatements = "off"
                                suspicious/noExplicitAny = "error"
                                suspicious/noExtraNonNullAssertion = "error"
                                suspicious/noFallthroughSwitchClause = "error"
                                suspicious/noFunctionAssign = "error"
                                suspicious/noGlobalAssign = "error"
                                suspicious/noImportAssign = "error"
                                suspicious/noLabelVar = "error"
                                suspicious/noMisleadingCharacterClass = "error"
                                suspicious/noMisleadingInstantiator = "error"
                                suspicious/noPrototypeBuiltins = "error"
                                suspicious/noRedeclare = "error"
                                suspicious/noSelfCompare = "error"
                                suspicious/noShadowRestrictedNames = "error"
                                suspicious/noUnsafeDeclarationMerging = "error"
                                suspicious/noUnsafeNegation = "error"
                                suspicious/useAwait = "off"
                                suspicious/useGetterReturn = "error"
                                suspicious/useValidTypeof = "error"

Workspace:
  Open Documents:               0

Rule name

N/A

Playground link

/

Expected result

Running locally:
image

It should not throw this error in GHA:
image

Code of Conduct

  • I agree to follow Biome's Code of Conduct
@wadehammes
Copy link
Author

I am migrating over from ESLint, and the existing config worked with it. I only updated to use biome, expected this to work the same but maybe I am missing something specific for GHA.

@wadehammes
Copy link
Author

For those that come across this, using biome lint . instead of a glob worked in CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant