Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📎 HTML: Implement "Bracket same line" option #4024

Open
Tracked by #4726
dyc3 opened this issue Sep 21, 2024 · 6 comments
Open
Tracked by #4726

📎 HTML: Implement "Bracket same line" option #4024

dyc3 opened this issue Sep 21, 2024 · 6 comments
Assignees
Labels
A-Formatter Area: formatter L-HTML Language: HTML S-Feature Status: new feature to implement

Comments

@dyc3
Copy link
Contributor

dyc3 commented Sep 21, 2024

Description

Add the option to HtmlFormatterSettings and implement the behavior.

See: https://prettier.io/docs/en/options.html#bracket-line

Before this can be started, this requires:

@dyc3 dyc3 added A-Formatter Area: formatter S-Feature Status: new feature to implement L-HTML Language: HTML labels Sep 21, 2024
@ematipico
Copy link
Member

This option should be a top level option now, because we already have one for JSX

https://biomejs.dev/reference/configuration/#javascriptformatterbracketsameline

We could add the top level one, deprecate the JSX option and provide a migration. This can be done in a patch release.

Then, in v2.0 we will remove the deprecated option. What do you think?

@dyc3
Copy link
Contributor Author

dyc3 commented Sep 22, 2024

Makes sense to me, since this option will also eventually apply to all HTML ish languages.

@JonathonRP

This comment was marked as off-topic.

@ematipico

This comment was marked as off-topic.

@JonathonRP
Copy link

@JonathonRP This is a technical issue; unless you want to help or have technical opinions, please refrain from asking "when an issue is ready", we're trying to avoid such comments. Something is ready when is ready.

Sorry, I had a use case. I'm using svelte and want the brackets on the same line. I was curious about the updates, I saw the one PR is merged but didn't see a PR for progressing this, I would be willing to help

@ematipico
Copy link
Member

Yeah exactly, nobody claimed the issue yet. If you're interested in helping, you're more than welcome 😁

You can use this issue to ask any questions, or even open a draft PR and start from asking questions there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Formatter Area: formatter L-HTML Language: HTML S-Feature Status: new feature to implement
Projects
None yet
Development

No branches or pull requests

3 participants