Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📎 Implement suppression of plugin diagnostics #4667

Open
Tracked by #3727
arendjr opened this issue Dec 1, 2024 · 2 comments
Open
Tracked by #3727

📎 Implement suppression of plugin diagnostics #4667

arendjr opened this issue Dec 1, 2024 · 2 comments
Assignees
Labels
A-Analyzer Area: analyzer A-Diagnostic Area: diagnostocis A-Plugins Area: plugins good first issue Good for newcomers S-Enhancement Status: Improve an existing feature
Milestone

Comments

@arendjr
Copy link
Contributor

arendjr commented Dec 1, 2024

Description

Plugin diagnostics currently cannot be suppressed by biome-ignore comments. We need to confirm what syntax we want to use, but I would suggest the following since it's pretty close to regular rules:

// biome-ignore plugin/myCustomPlugin: <reason>

Then the analyzer needs to be extended so the diagnostics are indeed suppressed. It's a relatively well-contained task, but does require some knowledge of the analyzer internals.

@arendjr arendjr added good first issue Good for newcomers A-Diagnostic Area: diagnostocis S-Enhancement Status: Improve an existing feature A-Analyzer Area: analyzer A-Plugins Area: plugins labels Dec 1, 2024
@arendjr arendjr added this to the Biome 2.0 milestone Dec 1, 2024
@wanghaoPolar
Copy link

Hi~ I read the related code on how suppression work, and have some basic idea how to implement this. Can you help to assign this to me? thanks!

I'll draft a simple design doc for review before start coding.

@wanghaoPolar
Copy link

hi @arendjr , can you help to check my RFC when you have time? thanks! #4720

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Analyzer Area: analyzer A-Diagnostic Area: diagnostocis A-Plugins Area: plugins good first issue Good for newcomers S-Enhancement Status: Improve an existing feature
Projects
None yet
Development

No branches or pull requests

2 participants