Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(configuration_schema): rename some fields to camelCase in the configuration_schema.json #2568

Merged
merged 1 commit into from
Apr 23, 2024
Merged

fix(configuration_schema): rename some fields to camelCase in the configuration_schema.json #2568

merged 1 commit into from
Apr 23, 2024

Conversation

ah-yu
Copy link
Contributor

@ah-yu ah-yu commented Apr 23, 2024

Summary

When I tried to enable the useImportType rule in the codebase I maintain at work, I found that jsxRuntime still uses snake_case in the configuration schema.

Test Plan

just gen-bindings

@github-actions github-actions bot added the A-Project Area: project label Apr 23, 2024
ematipico
ematipico approved these changes Apr 23, 2024
View reviewed changes
Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

@ematipico
Copy link
Member

I wonder if we should have something to catch these regressions. It's not the first time that happens

@Conaclos Conaclos mentioned this pull request Apr 23, 2024
Merged
@ah-yu ah-yu merged commit 52029f6 into biomejs:main Apr 23, 2024
10 checks passed
@ah-yu ah-yu deleted the configure_camelCase branch April 23, 2024 09:28
@Conaclos
Copy link
Member

Conaclos commented Apr 23, 2024 •
edited
Loading

@ah-yu Could you also fix the names of JsxRuntime enum members? See #2567

EDIT: too late

@ah-yu
Copy link
Contributor Author

ah-yu commented Apr 23, 2024

@Conaclos Not late 😅 , I'm still here. I can submit another PR to fix it.

@ah-yu ah-yu mentioned this pull request Apr 23, 2024
Merged
@Conaclos Conaclos mentioned this pull request Apr 23, 2024
Merged
@DeltaV93 DeltaV93 mentioned this pull request Jun 19, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ematipico ematipico ematipico approved these changes

Assignees
No one assigned
Labels
A-Project Area: project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ah-yu @ematipico @Conaclos