Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use Starlight tabs #227

Merged
merged 2 commits into from
May 3, 2024
Merged

feat: use Starlight tabs #227

merged 2 commits into from
May 3, 2024

Conversation

ematipico
Copy link
Member

@ematipico ematipico commented May 3, 2024 •
edited
Loading

Summary

This PR does the following:

  • Uses Starlight tabs instead of ours. I removed the internal script needed to keep the tabs in sync.
  • Removes the old SVGs that we don't use anyway. All the images we use are inside assets.
  • Fixes an issue where the blog posts have two open-graph images.

@netlify Netlify
Copy link

netlify bot commented May 3, 2024 •
edited
Loading

✅ Deploy Preview for biomejs ready!

Name Link
🔨 Latest commit 9d8cc22
🔍 Latest deploy log https://app.netlify.com/sites/biomejs/deploys/663519ae7beb820008517229
😎 Deploy Preview https://deploy-preview-227--biomejs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ematipico
Copy link
Member Author

I tested the OG fix, and it works :)

@ematipico ematipico merged commit 3ac2627 into main May 3, 2024
7 checks passed
@ematipico ematipico deleted the feat/new-tabs branch May 3, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ematipico