Update protocol submodule to master branch from #p27

[AntumArk]

@btsimonh Are you working to update protocol submodule? I am just trying to remind you in case you may forget.

[btsimonh]

I think it's done (it was a few mins after the main repo....)? pls confirm it all builds once both masters are pulled....

[AntumArk]

It is still detached head.

Building things now :D

[btsimonh]

subrepos - bahh... trying to fix it now!

[btsimonh]

pls check again. all should be good now.

[AntumArk]

@btsimonh Everything built successfully.

[AntumArk]

Ok, now it is latest commit, but still detached head.

You can't make PR to detached heads.

[btsimonh]

hmm... not seeing that through github or sourcetree....
Are you working from btsimonh or bipropellant? - they should be the same, but the btsimonh one is a little of a plaything.

[AntumArk]

bipropellant

Cloning with reccursive submodules using gitbash, then adding all repos to github desktop.

[btsimonh]

ok, I'll try a small mod on each and commit from github, change to readme maybe. one moment.

[AntumArk]

In the meantime I am trying to clone on Sourcetree

[AntumArk]

Same thing, it checks out on that specific commit.

Although it can handle submodules, where github desktop - not.

[p-h-a-i-l]

Well, detached head is "ok" when working with submodule. A submodule does not reference a branch or head, it references a single commit. This way you can make sure that the "main" repo decides which commit is ok.

You can open git in your submodule folder and checkout the correct branch. This way the head shouldnt be detached anymore.

[AntumArk]

@btsimonh It is now synced. Head is now synced upon cloning.

[EFeru]

@btsimonh, maybe you can update the Travis link in Readme to point to the bipropellant build check. At the moment it links to my fork Travis build.

[p-h-a-i-l]

@btsimonh, maybe you can update the Travis link in Readme to point to the bipropellant build check. At the moment it links to my fork Travis build.

done

[btsimonh]

In the meantime I am trying to clone on Sourcetree

I use sourcetree for all my windows git operations; it's not perfect for submodules, but I'm kind of getting used to it :).

[p-h-a-i-l]

I gave up on using a fancy GUI for git. Just using the built in functions from vscode and git bash.