-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Read radicals as corresponding kanji #1205
Comments
Not sure how often that happens in real-life text, but I think it makes sense to support this. |
Fixed in bc23d70 |
Version 1.15 has now been released which includes this fix. |
Sorry to dig this up, in current version radicals are recognized as kanjis when they are matched in the words dictionary, but in the Kanji tab only the proper kanjis are shown (kanjis that misencoded as radicals do not appear there). @birtles Is this intended behavior? I could see this cause some potential confusion. |
It's not intentional, I just never really thought much about the kanji tab behaviour. It's probably worth looking into if we can fix it. |
As reported on twitter: https://twitter.com/Koyama_Yamako/status/1668559058809282561
Specifically in this text:
「穎才新誌」の作⽂が抽象的⾔説に..
The ⽂ is using the radical U+2F42 instead of the kanji codepoint U+6587. Similarly for ⾔.
This is just a bug in the markup but we could map radicals to kanji codepoints where there is a clear corresponding counterpart. (For bonus points, we could preserve the original codepoint and show it in the kanji tab for easier debugging, or even show the radical information since we already store that in the database.)
The text was updated successfully, but these errors were encountered: