Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read radicals as corresponding kanji #1205

Closed
birtles opened this issue Jun 15, 2023 · 5 comments · Fixed by #1803
Closed

Read radicals as corresponding kanji #1205

birtles opened this issue Jun 15, 2023 · 5 comments · Fixed by #1803

Comments

@birtles
Copy link
Member

birtles commented Jun 15, 2023

As reported on twitter: https://twitter.com/Koyama_Yamako/status/1668559058809282561

Specifically in this text:

「穎才新誌」の作⽂が抽象的⾔説に..

The ⽂ is using the radical U+2F42 instead of the kanji codepoint U+6587. Similarly for ⾔.

This is just a bug in the markup but we could map radicals to kanji codepoints where there is a clear corresponding counterpart. (For bonus points, we could preserve the original codepoint and show it in the kanji tab for easier debugging, or even show the radical information since we already store that in the database.)

@Tomalak
Copy link

Tomalak commented Jun 17, 2023

Not sure how often that happens in real-life text, but I think it makes sense to support this.

@birtles
Copy link
Member Author

birtles commented Aug 28, 2023

Fixed in bc23d70

@birtles birtles closed this as completed Aug 28, 2023
@birtles
Copy link
Member Author

birtles commented Sep 13, 2023

Version 1.15 has now been released which includes this fix.

@SaltfishAmi
Copy link
Contributor

SaltfishAmi commented Oct 28, 2023

Sorry to dig this up, in current version radicals are recognized as kanjis when they are matched in the words dictionary, but in the Kanji tab only the proper kanjis are shown (kanjis that misencoded as radicals do not appear there).

image

@birtles Is this intended behavior? I could see this cause some potential confusion.

@birtles
Copy link
Member Author

birtles commented Oct 28, 2023

It's not intentional, I just never really thought much about the kanji tab behaviour. It's probably worth looking into if we can fix it.

@birtles birtles mentioned this issue Nov 27, 2023
11 tasks
@birtles birtles mentioned this issue Dec 6, 2023
7 tasks
@birtles birtles mentioned this issue Feb 26, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants