Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have a way to distinguish 'proof of burns' between ' burns by burning men' and 'burns for Bisq 2 reputation' #6730

Closed
pazza83 opened this issue Jun 12, 2023 · 3 comments · Fixed by #6741

Comments

@pazza83
Copy link

pazza83 commented Jun 12, 2023

Description

Similarly to #6729 it would be good if the section 'all proof of burn transactions' could be distinguished between:

  • Burns by burning men
  • Burns for Bisq 2 reputation
  • Other burns

I would propose adding the the following data to the burns:

  • Burning Men
  • Bisq 2 reputation
  • Other

When burning BSQ in 'DAO > Proof of Burn > Proof of Burn' users could be given the option of selecting a reason for the burn between 'Bisq 2 reputation' or 'Other'.

Capture2

Burning on 'Proof of Burn > Burning Men' could be automatically tagged as 'Burning Men'

Capture3

The reason for the burning of BSQ could then be shown in the 'all proof of burn transactions' section:

Capture

This would make for accounting easier as revenue between both Bisq 1 Burning Men and Bisq 2 burning for reputation could be quickly distinguished.

For example an extra column on the image above to show the 'Reason' for the burning of BSQ.

@HenrikJannsen
Copy link
Collaborator

HenrikJannsen commented Jun 23, 2023

Not sure if thats possible with current model. We use just the hash of the preimage with a byte for the version and one for the proofOfWork tx type. We would more another prefix bytes to distinguish the reasons for the burn.
Another hack could be to replace the first 1-2 bytes of the hash with the prefix. But would need to look closer into it if it would have impact on DAO consensus.
For BM we would have the data in BM domain, so I guess there is no need beside for double checking to get that data from the POB.
For Bisq2 I need to look into the details. There that hack to replace some bytes of the hash with a marker could work, of if there is no size limit from DAO consensus side (I guess there is) we could just add those.
But also there it will go over the Bisq1BridgeNode and there we could get some aggregated data.

@pazza83
Copy link
Author

pazza83 commented Jun 23, 2023

Thanks for the explanation.

Another way to distinguish 'proof of burns' between ' burns by burning men' and 'burns for Bisq 2 reputation' would be to include the amount of BSQ burned by burning men per month in the 'Report' function in DAO > Proof of Burn > Burning Men.

This would allow for the total Burnt in BSQ per month to be easily accessed.

And if #6729 was implemented then 'Total BSQ burns' - 'Burns by Burningmen' = BSQ burnt for reputation and other.

@HenrikJannsen
Copy link
Collaborator

Yes I was thinking also to add that. Maybe @jmacxx has some bandwidth to do that. If not ping me again and I will look at it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants