Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For cycle 21 #736

Closed
oscarguindzberg opened this issue Dec 9, 2020 · 21 comments
Closed

For cycle 21 #736

oscarguindzberg opened this issue Dec 9, 2020 · 21 comments
Assignees
Labels
parsed:invalid https://bisq.wiki/Compensation#Ensure_your_request_is_valid team:dev https://bisq.wiki/Dev_Team was:accepted Indicates that a compensation request was accepted by DAO voting
Milestone

Comments

@oscarguindzberg
Copy link

oscarguindzberg commented Dec 9, 2020

Summary

Specify the total amount of BSQ you are requesting, along with the USD total and BSQ/USD rate (don't include the brackets!):

  • BSQ requested: 7142.86
  • USD requested: 5000
  • BSQ rate: [rate] USD per BSQ 0.70
  • Previous compensation request (if applicable): For cycle 19 #710

Contributions delivered

Add contributions you have delivered and roles you have performed here as new rows in the table below. Role line-items should include an asterisk (*) in the team column.

Title Team USD Link Notes
Post deployment support dev 5000 See list bellow

Detailed list of contributions:

Context:
bisq-network/projects#42
bisq-network/proposals#247

Contributions in progress

Provide links to work you're involved with that is still in progress. This section is optional (the linter ignores it), and is for your own benefit in keeping track of what you're doing and keeping other contributors up to date with the same.

@oscarguindzberg oscarguindzberg changed the title [WIP] For cycle 20 For cycle 20 Dec 10, 2020
@ghost ghost added the parsed:invalid https://bisq.wiki/Compensation#Ensure_your_request_is_valid label Dec 10, 2020
@ghost
Copy link

ghost commented Dec 10, 2020

Info

Read BSQ amount from summary: 714286
Read USD amount from summary: 5000
Parsed lineitem: {"team":"dev","amount":5000}

Errors

ERROR: Total BSQ does not match the sum of line items:

  • Summary total: 714286.00 BSQ
  • Calculated total: 7462.69 BSQ

@ghost ghost added the team:dev https://bisq.wiki/Dev_Team label Dec 10, 2020
@ghost
Copy link

ghost commented Dec 10, 2020

Info

Read BSQ amount from summary: 7142.86
Read USD amount from summary: 5000
Parsed lineitem: {"team":"dev","amount":5000}

Errors

ERROR: Total BSQ does not match the sum of line items:

  • Summary total: 7142.86 BSQ
  • Calculated total: 7462.69 BSQ

1 similar comment
@ghost
Copy link

ghost commented Dec 10, 2020

Info

Read BSQ amount from summary: 7142.86
Read USD amount from summary: 5000
Parsed lineitem: {"team":"dev","amount":5000}

Errors

ERROR: Total BSQ does not match the sum of line items:

  • Summary total: 7142.86 BSQ
  • Calculated total: 7462.69 BSQ

@oscarguindzberg
Copy link
Author

don't know why bisq-bot does its math with BSQ rate 0.67. It should be 0.70

@ghost
Copy link

ghost commented Dec 10, 2020

Info

Read BSQ amount from summary: 7142.86
Read USD amount from summary: 5000
Parsed lineitem: {"team":"dev","amount":5000}

Errors

ERROR: Total BSQ does not match the sum of line items:

  • Summary total: 7142.86 BSQ
  • Calculated total: 7462.69 BSQ

@oscarguindzberg
Copy link
Author

This compensation proposal is subject to the terms of DAO proposal 247 bisq-network/proposals#247 and will be paid from the special BTC multisig escrow to @oscarguindzberg as follows, pending DAO approval in Cycle 20 voting:
USD: 5000

BSQ: 5000 / .70 = 7142.86 BSQ

BTC: 7142.86 * 0,00004887 = 0,34907156, minus 0,00714286 BTC for comp req = 0,3419287082 BTC net to oscar

Note: Using 30 days average 4887 sats BSQ/BTC rate from screenshot below taken at the time of compensation proposal creation

bsq-rate

@MwithM
Copy link
Contributor

MwithM commented Dec 10, 2020

I suggest you this to have your compensation parsed by the bot:


- **BSQ requested**: **`7142.86`** <!-- [BSQ amount] should be: USD amount / BSQ rate -->
- USD requested: 5000 <!-- [USD amount] should be: total of all contributions listed in "contributions delivered" table below -->
- BSQ rate: 0.7 USD per BSQ

@oscarguindzberg
Copy link
Author

@MwithM I do not understand what you mean.

@MwithM
Copy link
Contributor

MwithM commented Dec 10, 2020

Edit to use:
- BSQ rate: 0.7 USD per BSQ
Instead of:
- BSQ rate: [rate] USD per BSQ 0.70

@ghost ghost added parsed:valid https://bisq.wiki/Compensation#Ensure_your_request_is_valid and removed parsed:invalid https://bisq.wiki/Compensation#Ensure_your_request_is_valid labels Dec 10, 2020
@oscarguindzberg
Copy link
Author

oscarguindzberg commented Dec 12, 2020

@wiz @sqrrm @ripcurlx please, could you confirm the rate of 4887 sats BSQ/BTC as of Dec 9th 2020? thanks

@wiz
Copy link

wiz commented Dec 16, 2020

Sorry, just saw this now. Looks like the rate has declined a bit since then, but looking at the recent trades, it seems the rate you used at time of compensation proposal creation was what it was at the time.

Screen Shot 2020-12-17 at 6 28 36

@MwithM MwithM added this to the Cycle 20 milestone Dec 27, 2020
@ripcurlx
Copy link
Contributor

As team lead I approve this request. Please submit your DAO proposal and paste the transaction ID here as a comment when complete, thanks.

@MwithM
Copy link
Contributor

MwithM commented Jan 3, 2021

Please submit in a comment the TXID for DAO copensation request.

@oscarguindzberg
Copy link
Author

3d4c102214929cbd58b21efaa78abf995620064d02dbb74bb7740fc20a02fbf9

@MwithM MwithM added the was:failed Indicates that DAO vote failed to complete. label Jan 10, 2021
@MwithM
Copy link
Contributor

MwithM commented Jan 10, 2021

Cycle 20 DAO vote failed. Submit a new DAO request for next cycle.

@MwithM MwithM closed this as completed Jan 10, 2021
@MwithM
Copy link
Contributor

MwithM commented Feb 1, 2021

@oscarguindzberg
Could you confirm that you have submitted the request with TXID 7053913491640f03819aa1b426453573cad3dc6fb3cba3f5b5f9ae78d1ef475d ?

It should have been opened as a new issue for Cycle 21. You probably missed the channels where this was informed through (you're not part of https://github.com/orgs/bisq-network/teams/dao/discussions/ and probably you're not at compensation Keybase channel).

@MwithM MwithM reopened this Feb 1, 2021
@oscarguindzberg
Copy link
Author

@MwithM It was the guarantor who submitted tx id 7053913491640f03819aa1b426453573cad3dc6fb3cba3f5b5f9ae78d1ef475d. He is going to receive the BSQ.
@wiz @sqrrm please, let me know if I have to do something.

@MwithM MwithM changed the title For cycle 20 For cycle 21 Feb 2, 2021
@ghost ghost added parsed:invalid https://bisq.wiki/Compensation#Ensure_your_request_is_valid and removed parsed:valid https://bisq.wiki/Compensation#Ensure_your_request_is_valid labels Feb 2, 2021
@ghost
Copy link

ghost commented Feb 2, 2021

Info

Read BSQ amount from summary: 7142.86
Read USD amount from summary: 5000
Parsed lineitem: {"team":"dev","amount":5000}

Errors

ERROR: Total BSQ does not match the sum of line items:

  • Summary total: 7142.86 BSQ
  • Calculated total: 6666.67 BSQ

@MwithM MwithM modified the milestones: Cycle 20, Cycle 21 Feb 2, 2021
@ripcurlx
Copy link
Contributor

ripcurlx commented Feb 7, 2021

Info

Read BSQ amount from summary: 7142.86
Read USD amount from summary: 5000
Parsed lineitem: {"team":"dev","amount":5000}

Errors

ERROR: Total BSQ does not match the sum of line items:

  • Summary total: 7142.86 BSQ
  • Calculated total: 6666.67 BSQ

The validation issue is because this CR was initially posted for cycle 20 where the USD/BSQ rate was 0,70, but in this cycle (21) it was adapted to 0,75.

@MwithM MwithM added the was:accepted Indicates that a compensation request was accepted by DAO voting label Feb 10, 2021
@ghost
Copy link

ghost commented Feb 10, 2021

Issuance cannot be displayed as there were errors in the comp request

@MwithM
Copy link
Contributor

MwithM commented Feb 10, 2021

Closed as accepted

@MwithM MwithM closed this as completed Feb 10, 2021
@m52go m52go removed the was:failed Indicates that DAO vote failed to complete. label Feb 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
parsed:invalid https://bisq.wiki/Compensation#Ensure_your_request_is_valid team:dev https://bisq.wiki/Dev_Team was:accepted Indicates that a compensation request was accepted by DAO voting
Projects
Archived in project
Development

No branches or pull requests

5 participants