Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For Cycle 22 #791

Closed
ghost opened this issue Feb 28, 2021 · 7 comments
Closed

For Cycle 22 #791

ghost opened this issue Feb 28, 2021 · 7 comments
Assignees
Labels
parsed:valid https://bisq.wiki/Compensation#Ensure_your_request_is_valid team:dev https://bisq.wiki/Dev_Team team:ops https://bisq.wiki/Ops_Team was:accepted Indicates that a compensation request was accepted by DAO voting
Milestone

Comments

@ghost
Copy link

ghost commented Feb 28, 2021

Summary

  • BSQ requested: 1493
  • USD requested: 1807
  • BSQ rate: 1.21 USD per BSQ
  • Previous compensation request (if applicable): For Cycle 21 #763

Contributions delivered

[edit 1] added 2 merged items bisq-network/bisq#5235, bisq-network/bisq#5267; increased request amount by 5%

Add contributions you have delivered here as new rows in the table below. See comments below the table for guidance.

Title Team USD Link Notes
Fix mailbox bootstrap issue dev 105 bisq-network/bisq#5267 1.5.9
Obtain minimumFee from mempool api in place of hardcoded value ops 157 bisq-network/bisq#5235 1.5.8
Start pricenode providers asynchronously ops 210 bisq-network/bisq#4890 1.5.7
Fix startup error: "You must have bootstrapped before adding data to the P2P network" dev 210 bisq-network/bisq#5191 1.5.6
New Feature: Pre-release notifications dev 210 bisq-network/bisq#5108 1.5.7
Specify Amazon eGift Card country dev 105 bisq-network/bisq#5117 1.5.7
Wording change for CashByMail dev 0 bisq-network/bisq#5118 1.5.5
Add four SEPA Payment Account countries: AD, SM, VA, JE. dev 25 bisq-network/bisq#5123 1.5.7
Replace deprecated bisq explorer settings dev 0 bisq-network/bisq#5137 1.5.7
Fix NPE at offer entry when trading account switched dev 210 bisq-network/bisq#5172 1.5.7
Fix NPE in trader chat dev 210 bisq-network/bisq#5175 1.5.7
Refund agent payout to use withdrawal fee rate from settings dev 25 bisq-network/bisq#5178 1.5.7
Prevent erroneous logging of 'SignaturePubKey in message does not match' dev 105 bisq-network/bisq#5196 1.5.7
Fix initialization ordering issue dev 210 bisq-network/bisq#5219 1.5.7
Increase min withdrawal tx fee to 15 sats/vB dev 25 bisq-network/bisq#5224 1.5.7

 

Other contributions

  • support/troubleshooting.
  • helped with release testing
  • maintenance of compensation-bot

 

Contributions in progress

Title Team USD Link Notes
Improve mediation tools. dev 0 bisq-network/bisq#5206 awaiting review
Fix Multiple Warnings on Enable All Offers dev bisq-network/bisq#5215 awaiting review
Provide a reliable lightweight monitor with notifications dev bisq-network/projects#45
Verify maker & taker fee transactions via Mempool lookup dev bisq-network/bisq#5160
Improve chat functionality of mediation/arbitration dev bisq-network/bisq#5207
@ghost ghost added parsed:valid https://bisq.wiki/Compensation#Ensure_your_request_is_valid team:ops https://bisq.wiki/Ops_Team team:dev https://bisq.wiki/Dev_Team labels Feb 28, 2021
@MwithM MwithM self-assigned this Feb 28, 2021
@MwithM MwithM added this to the Cycle 22 milestone Feb 28, 2021
@MwithM MwithM assigned ripcurlx and wiz and unassigned MwithM Feb 28, 2021
@chimp1984
Copy link

Have not followed in details, but from my feeling that seems too low. You are covering a lot of the bug fixing and support dev work and I think you should ask for a more appropriate compensation.

@wiz
Copy link

wiz commented Mar 3, 2021

Approved for ops. I agree the comp req amounts seem very low, you should ask for more.

@wiz wiz removed their assignment Mar 3, 2021
@ghost
Copy link
Author

ghost commented Mar 3, 2021

@chimp1984 @wiz Thankyou for your support, it is not easy to price these things so your comments are appreciated.
I have added 2 recently merged items and increased the requested amount by 5%.

bisq-network/bisq#5267
bisq-network/bisq#5235

@ripcurlx
Copy link
Contributor

ripcurlx commented Mar 3, 2021

As team lead I approve this request for dev and I agree with what was mentioned in the comments before.

@ghost
Copy link
Author

ghost commented Mar 7, 2021

159d7e31cc1d833bc75c5cb411e5c6918d6f213423089d51ac28e05e027e0eb3

@MwithM MwithM added the was:accepted Indicates that a compensation request was accepted by DAO voting label Mar 15, 2021
@ghost
Copy link

ghost commented Mar 15, 2021

Issuance by Team:

team amount BSQ amount USD
dev 1189.77 1440.00
ops 303.23 367.00

Total Issuance: 1493.00 BSQ (equivalent to: 1807.00 USD)

@MwithM
Copy link
Contributor

MwithM commented Mar 15, 2021

Closed as accepted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
parsed:valid https://bisq.wiki/Compensation#Ensure_your_request_is_valid team:dev https://bisq.wiki/Dev_Team team:ops https://bisq.wiki/Ops_Team was:accepted Indicates that a compensation request was accepted by DAO voting
Projects
Archived in project
Development

No branches or pull requests

4 participants