You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We can not add secp256k1_ecdsa_sign_recoverable to valgrind_ctime_tests (added in PR #708) because it is mostly a copy of the old ecdsa_sign function which was not constant time in edge cases. Instead of fixing sign_recoverable and again having duplicate code we should add an internal function with the code shared between the two functions (similar to ab4fd52).
Let's get #701 in first because it also touches ecdsa_sign.
The text was updated successfully, but these errors were encountered:
We can not add
secp256k1_ecdsa_sign_recoverable
tovalgrind_ctime_tests
(added in PR #708) because it is mostly a copy of the oldecdsa_sign
function which was not constant time in edge cases. Instead of fixingsign_recoverable
and again having duplicate code we should add an internal function with the code shared between the two functions (similar to ab4fd52).Let's get #701 in first because it also touches
ecdsa_sign
.The text was updated successfully, but these errors were encountered: