Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make use of constant time ecdsa_sign code in ecdsa_sign_recoverable #725

Closed
jonasnick opened this issue Mar 23, 2020 · 1 comment · Fixed by #755
Closed

Make use of constant time ecdsa_sign code in ecdsa_sign_recoverable #725

jonasnick opened this issue Mar 23, 2020 · 1 comment · Fixed by #755

Comments

@jonasnick
Copy link
Contributor

We can not add secp256k1_ecdsa_sign_recoverable to valgrind_ctime_tests (added in PR #708) because it is mostly a copy of the old ecdsa_sign function which was not constant time in edge cases. Instead of fixing sign_recoverable and again having duplicate code we should add an internal function with the code shared between the two functions (similar to ab4fd52).

Let's get #701 in first because it also touches ecdsa_sign.

@elichai
Copy link
Contributor

elichai commented Jun 8, 2020

@jonasnick hehe I didn't know this issue existed :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants