Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: Fix cache issue when integrating by downstream project #1529

Merged
merged 2 commits into from
Jun 12, 2024
Merged

cmake: Fix cache issue when integrating by downstream project #1529

merged 2 commits into from
Jun 12, 2024

Commits on May 11, 2024

  1. cmake: Do not set emulated PROJECT_IS_TOP_LEVEL as cache variable 

    Otherwise, downstream projects, which integrate the libsecp256k1 library
using the `add_subdirectory()` command, will be affected.
    @hebasto
    hebasto committed May 11, 2024
    Configuration menu
    Copy the full SHA
    cae9a7a View commit details
    Browse the repository at this point in the history

  2. cmake: Simplify PROJECT_IS_TOP_LEVEL emulation 

    Detecting whether it is the top level by comparing the value of
`CMAKE_SOURCE_DIR` with `CMAKE_CURRENT_SOURCE_DIR` is supported by all
versions of CMake and is a very common pattern.
    @hebasto
    hebasto committed May 11, 2024
    Configuration menu
    Copy the full SHA
    ec4c002 View commit details
    Browse the repository at this point in the history