-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BIP 43: Reserve purpose codes 10001-19999 for SLIPs #523
Conversation
👍 |
I don't mind |
NACK on deterministic scheme for alts. BIPs are for Bitcoin only and should not dictate a scheme for alts: #76 (comment) Plus, the wallets have determined a scheme using BIP44. ACK on purpose code allocation for SLIPs though. |
It doesn't dictate anything, merely reserves a path for altcoin standards processes to use. BIP 44 does not suffice for this purpose. For example, see ethereum/EIPs#600 |
They can already do this. They can use any purpose constant they want.
It suffices just fine - 10 wallets use it: ethereum/EIPs#84 (comment) There was discussion about this over a year ago: ethereum/EIPs#84 BIP44/43 are sufficient as-is. The only thing this PR should be concerned about is the reservation of the purpose constants for SLIPs. |
Without coordination, however, the chance of more than one coin using the same constant is very high.
The link you provide illustrates exactly why it doesn't work well: the BIP44 scheme is poorly suited to coins that don't use UTXO mechanisms, resulting in different wallets interpreting it differently and using incompatible derivation paths. The 10 wallets you mention are using 3 different mutually incompatible derivation paths. |
bip-0043.mediawiki
Outdated
In this case, the level immediately below the purpose code is hardened derivation using the index for the cryptocoin specified by [[https://github.com/satoshilabs/slips/blob/master/slip-0044.md|SLIP-0044]]. | ||
The details of levels below this coin type are to be entirely decided by the standard process of the specific cryptocoin, but it is recommended that the very next level be a sub-purpose code with a similar use as this BIP's purpose code. | ||
|
||
So that the recommended use for non-Bitcoin cryptocoins is: | ||
|
||
<pre> | ||
m / 43' / coin_type' / subpurpose' / ... | ||
</pre> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could this PR get merged if someone pulls out this specification to some other place, such that you do no more than reserving 43 here?
If we write a new SLIP-0043 with the suggested content, we can reduce this PR to a single sentence:
This would delegate what the purpose 43 does and at the same time point to the usage of 13 and 48. |
ACK for nACK for the rest. Altcoins are not and will not follow this. Please rework the PR to contain only the first change. |
678ca14
to
cb89563
Compare
@slush0 @prusnak
cc @Arachnid