Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Integration tests for bdk-cli #62

Closed
rajarshimaitra opened this issue Dec 8, 2021 · 3 comments · Fixed by #102
Closed

Create Integration tests for bdk-cli #62

rajarshimaitra opened this issue Dec 8, 2021 · 3 comments · Fixed by #102
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@rajarshimaitra
Copy link
Contributor

After Proof of Reserves capability is merged in bitcoindevkit/bdk@b2ac4a0, its time we require some integration tests in the library. Not only for Proof of Reserves functionality, but in general wallet functions too.

This then can be added into CI tests to give us better reliability on the underlying bdk functions.

electrsd can be used similarly to the bdk test framework to simulate a electrum and bitcoin core backend. https://github.com/bitcoindevkit/bdk/blob/64e88f0e006c68315142d53dc35b633327dde4b5/src/testutils/blockchain_tests.rs#L19-L22

@rajarshimaitra rajarshimaitra added enhancement New feature or request good first issue Good for newcomers labels Dec 8, 2021
@rajarshimaitra rajarshimaitra self-assigned this Mar 7, 2022
@notmandatory notmandatory added this to the Release 0.5.x milestone Mar 14, 2022
@notmandatory notmandatory moved this from Todo to Ready to Review in BDK-CLI Roadmap Mar 14, 2022
@rajarshimaitra rajarshimaitra moved this from Ready to Review to In Progress in BDK-CLI Roadmap Apr 29, 2022
@rajarshimaitra rajarshimaitra removed the good first issue Good for newcomers label May 10, 2022
@rajarshimaitra
Copy link
Contributor Author

This has turned out to be more elaborate than I thought.. Definitely not good first issue.. I will include this in an upcoming regtest-node part2 PR..

@notmandatory
Copy link
Member

I'm going to merge #89 and #71 for 0.5.0 and then I think we should release it. Can we move this issue to next milestone 0.6.0?

@rajarshimaitra
Copy link
Contributor Author

rajarshimaitra commented May 12, 2022

Yes I also feel we should release the current bunch before that change, and push this to next release.. Because that PR will have some upstream pendings..

  • electrsd - Waiting for Update node initiation to handle Persistent DB rust-bitcoin/bitcoind#61 and a new electrsd release.

  • bdk v0.190 (maybe?) - To include bitcoincore-rpc v0.15.0 which is dependency of latest electrsd . Which I saw Alekos already did in the taproot PR. Without that the code will have compile time conflict because it uses bitcoincore-rpc from two different crates.. bdk v0.18.0 will have dependency version conflict in that PR. We can probably work around it in cargo with patches until bitcoincore-rpc v0.15.0 gets into bdk in next release.

I will open the PR shortly though with those temporary fixes, so we can discuss over the node communication approach and improving the test framework..

@notmandatory notmandatory removed this from the Release 0.6.0 milestone Jun 21, 2022
@notmandatory notmandatory added this to the Release 0.7.0 milestone Jul 14, 2022
Repository owner moved this from In Progress to Done in BDK-CLI Roadmap Sep 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment