-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create Integration tests for bdk-cli #62
Comments
This has turned out to be more elaborate than I thought.. Definitely not good first issue.. I will include this in an upcoming regtest-node part2 PR.. |
Yes I also feel we should release the current bunch before that change, and push this to next release.. Because that PR will have some upstream pendings..
I will open the PR shortly though with those temporary fixes, so we can discuss over the node communication approach and improving the test framework.. |
After Proof of Reserves capability is merged in bitcoindevkit/bdk@b2ac4a0, its time we require some integration tests in the library. Not only for Proof of Reserves functionality, but in general wallet functions too.
This then can be added into CI tests to give us better reliability on the underlying bdk functions.
electrsd can be used similarly to the bdk test framework to simulate a electrum and bitcoin core backend. https://github.com/bitcoindevkit/bdk/blob/64e88f0e006c68315142d53dc35b633327dde4b5/src/testutils/blockchain_tests.rs#L19-L22
The text was updated successfully, but these errors were encountered: