Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unneeded Wallet functions #1622

Open
notmandatory opened this issue Sep 25, 2024 · 0 comments
Open

Remove unneeded Wallet functions #1622

notmandatory opened this issue Sep 25, 2024 · 0 comments
Assignees
@notmandatory
Labels
api A breaking API change
Milestone
1.0.0-beta

Comments

@notmandatory
Copy link
Member

notmandatory commented Sep 25, 2024 •
edited
Loading

As we were reviewing which Wallet functions to expose in the language bindings we found some functions that likely aren't needed by Wallet users. I'll use this issue to list which ones I don't think are needed or can be called directly on LocalChain. Comment below if you have any other suggestions.

I'd like to remove any unneeded ones now before we have a final 1.0 API.
@notmandatory notmandatory self-assigned this Sep 25, 2024
@notmandatory notmandatory added the api A breaking API change label Sep 25, 2024
@notmandatory notmandatory added this to the 1.0.0-beta milestone Sep 25, 2024
@notmandatory notmandatory changed the title Review and remove unneeded bdk_wallet functions Review and remove unneeded Wallet functions Sep 25, 2024
@notmandatory notmandatory changed the title Review and remove unneeded Wallet functions Remove unneeded Wallet functions Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@notmandatory notmandatory

Labels
api A breaking API change
Projects
BDK
Status: Discussion
Milestone
1.0.0-beta
Development

No branches or pull requests
1 participant
@notmandatory