Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Would be cool if TxBuilder could have a getter for the total fee as calculation on the current template #1628

Open
stevenroose opened this issue Sep 26, 2024 · 3 comments
Labels
discussion There's still a discussion ongoing

Comments

@stevenroose
Copy link
Contributor

I think the title speaks for itself, but right now there is a "feerate" and "absolute fee" setter on txbuilder. I know it's probably not trivial to do in the current architecture, but it would be really cool if the txbuilder would have a getter that can tell you what the current total fee is.

@tnull
Copy link
Contributor

tnull commented Oct 1, 2024

+1, would be really handy.

@aruokhai
Copy link

aruokhai commented Oct 29, 2024

Can I Take this ?

@LLFourn
Copy link
Contributor

LLFourn commented Oct 29, 2024

I think this is impossible since coin selection hasn't been done yet?
I think the right thing to query is the PSBT about its fee.

@notmandatory notmandatory added this to BDK Nov 14, 2024
@notmandatory notmandatory added the discussion There's still a discussion ongoing label Nov 15, 2024
@notmandatory notmandatory moved this to Discussion in BDK Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion There's still a discussion ongoing
Projects
Status: Discussion
Development

No branches or pull requests

5 participants