-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wallet::get_address should return an Result #996
Comments
Is this part of 1.0 version or should I assign it to maintenance? |
Thanks i put 1.0.0 on now. |
@LLFourn FYI I removed the 1.0.0 milestone both from this and from the #1005 issue since we are using the Project "BDK 1.0" for issues / PRs related in general to 1.0 version. We use the milestones (alpha.1, alpha.2 ...) to signal the "sub-version" in which the specific ticket will eventually be delivered in |
This should be fixed before |
Removed from alpha.1, can see if able to get enough review for alpha.2. |
Since the persistent backend is fallible. There are
expect("TODO")
in there now which seem to have slipped through the cracks. It would be good to differentiate between those calls that are fallible and those that are infallible.I think
AddressIndex
should go in favor of different methods that return different addresses since the error cases seem to be different.I think with an infallible persistence backend we can have
new_address
but if it's fallible then it should betry_new_address
and return aResult
.cc @notmandatory. IIRC you were thinking about how to redesign this.
The text was updated successfully, but these errors were encountered: