Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unreproducible tests #142

Open
storopoli opened this issue Aug 8, 2024 · 1 comment
Open

Fix unreproducible tests #142

storopoli opened this issue Aug 8, 2024 · 1 comment

Comments

@storopoli
Copy link

          > The tests are CRAZY! They are even not reproducible. They pretty much ping a live server `electrum.blockstream.info:50001`. So I added the tests for the fees to make sure that the fee is `> 0`.

Maybe we should switch to use a local regtest electrs that we pre-populate with a certain amount of transactions and blocks to make them ~reproducible? Or, we could consider building a mock Electrum server, which shouldn't be hard to do? Especially given the confusion around fee rate conversion it would be good to test it properly in CI?

Originally posted by @tnull in #136 (comment)

@oleonardolima
Copy link
Collaborator

I do like the idea of using a local regtest electrs, by using electrsd for example.

I also think it'll be pretty much straightforward if we choose to use our bdk_testenv crate instead of trying to rebuild everything from scratch again with electrsd.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants