Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Async support? #96

Open
Kixunil opened this issue Feb 15, 2023 · 14 comments
Open

Async support? #96

Kixunil opened this issue Feb 15, 2023 · 14 comments

Comments

@Kixunil
Copy link

Kixunil commented Feb 15, 2023

As a networking-related dependency, this would be a great candidate for making it async.

@oleonardolima
Copy link
Collaborator

As I mentioned at bitcoindevkit/bdk#66 I guess it would also make it possible to add Tor support using arti-client.

@Kixunil
Copy link
Author

Kixunil commented Oct 24, 2023

@oleonardolima I think just make it possible to switch up any transport layer using a trait. Probably tokio::AsyncRead etc.

@oleonardolima
Copy link
Collaborator

Good, that makes sense. I'll try to take a look at it after adding the support on rust-esplora-client

@Kixunil
Copy link
Author

Kixunil commented Oct 27, 2023

@oleonardolima FYI I hand-wrote an async client with a few methods that were required for my project. I may be able to publish it as it may serve as a starting point.

@oleonardolima
Copy link
Collaborator

@Kixunil Cool! Thanks, that would be really helpful and a great starting point.

@RCasatta
Copy link
Member

RCasatta commented Dec 14, 2023

I just finished here thinking to trying to use arti_client with rust-electrum-client but noting that is async based while this is not.

Even some temporary hack like SyncIoBridge seems not easily applicable here, because the stream is not handled splitted (separated Read/Write)

@Kixunil
Copy link
Author

Kixunil commented Dec 14, 2023

@RCasatta yeah, IIRC that's why I ended up writing my own and as I did I found that the whole thing is quite involved.

@oleonardolima sorry to keep you waiting this long I will try soon.

@oleonardolima
Copy link
Collaborator

@Kixunil No worries, I'm still working on fedimint and rust-esplora-client tor support at the moment, but let me know when you do it.

@Kixunil
Copy link
Author

Kixunil commented Dec 15, 2023

It's out now: https://github.com/Kixunil/async-electrum-client

@oleonardolima
Copy link
Collaborator

update: I'll probably start working on this during this week, using the @Kixunil work as a starting point.

Do you have any other approach in mind @RCasatta ?

@RCasatta
Copy link
Member

Do you have any other approach in mind @RCasatta ?

No

@jurvis
Copy link

jurvis commented May 2, 2024

@oleonardolima curious, are you still actively working on this?

@oleonardolima
Copy link
Collaborator

@jurvis I'm not currently working on this, other issues took priority, although it's still on my list. Is it a pressing issue/feature that you need?

@jurvis
Copy link

jurvis commented May 3, 2024

@oleonardolima not pressing, just asking! do you have a draft branch going somewhere?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants