From cb0bbe2e244ba240622d65432267bdeec4a3b8d4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Miguel=20Ju=C3=A1rez=20L=C3=B3pez?= Date: Thu, 5 Sep 2024 14:52:30 -0400 Subject: [PATCH] [sdk] Include 3XX http responses in success results (#25) * [sdk] Include 3XX http responses in success results * [sdk] Include 3XX http responses in success results --- .../capture/network/okhttp/CaptureOkHttpEventListener.kt | 5 ++--- platform/swift/source/network/native/HTTPStatus.swift | 3 +-- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/platform/jvm/capture/src/main/kotlin/io/bitdrift/capture/network/okhttp/CaptureOkHttpEventListener.kt b/platform/jvm/capture/src/main/kotlin/io/bitdrift/capture/network/okhttp/CaptureOkHttpEventListener.kt index 859d365..f7d74ac 100644 --- a/platform/jvm/capture/src/main/kotlin/io/bitdrift/capture/network/okhttp/CaptureOkHttpEventListener.kt +++ b/platform/jvm/capture/src/main/kotlin/io/bitdrift/capture/network/okhttp/CaptureOkHttpEventListener.kt @@ -223,8 +223,7 @@ internal class CaptureOkHttpEventListener internal constructor( // Do not use OkHttp's `isSuccess` logic for determining whether a given response is // successful or not to keep iOS and Android implementation in sync. - val isSuccess = (statusCode in 200..<300) || - statusCode == 304 // "Not Modified" status code + val isSuccess = (statusCode in 200..<400) // Capture response URL attributes in case there was a redirect and attributes such as host, // path, and query have different values for the original request and the response. @@ -238,7 +237,7 @@ internal class CaptureOkHttpEventListener internal constructor( } else { HttpResponse.HttpResult.FAILURE }, - statusCode = response.code, + statusCode = statusCode, headers = response.headers.toMap(), ) diff --git a/platform/swift/source/network/native/HTTPStatus.swift b/platform/swift/source/network/native/HTTPStatus.swift index 44fdff3..8f279bc 100644 --- a/platform/swift/source/network/native/HTTPStatus.swift +++ b/platform/swift/source/network/native/HTTPStatus.swift @@ -57,7 +57,6 @@ struct HTTPStatus { private extension Int { var isSuccess: Bool { - return (200..<300).contains(self) - || self == 304 // "Not Modified" status code + return (200..<400).contains(self) } }