Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

panic: send on closed channel #218

Open
1 of 4 tasks
calj opened this issue Jul 25, 2020 · 2 comments
Open
1 of 4 tasks

panic: send on closed channel #218

calj opened this issue Jul 25, 2020 · 2 comments
Labels

Comments

@calj
Copy link
Contributor

calj commented Jul 25, 2020

Issue type

  • bug
  • missing functionality
  • performance
  • feature request

Brief description

panic: send on closed channel

goroutine 838 [running]:
github.com/bitfinexcom/bitfinex-api-go/v2/websocket.(*Client).handlePrivateChannel(0xc0001f62c0, 0xc000782c00, 0x3, 0x4, 0x0, 0x0)
	/go/pkg/mod/github.com/bitfinexcom/bitfinex-api-go@v0.0.0-20200207184043-4d37e8d4be18/v2/websocket/channels.go:153 +0x2be
github.com/bitfinexcom/bitfinex-api-go/v2/websocket.(*Client).handleChannel(0xc0001f62c0, 0x0, 0xc0007d7000, 0x795, 0xe00, 0x0, 0x0)
	/go/pkg/mod/github.com/bitfinexcom/bitfinex-api-go@v0.0.0-20200207184043-4d37e8d4be18/v2/websocket/channels.go:53 +0x572
github.com/bitfinexcom/bitfinex-api-go/v2/websocket.(*Client).handleMessage(0xc0001f62c0, 0x0, 0xc0007d7000, 0x795, 0xe00, 0x0, 0x0)
	/go/pkg/mod/github.com/bitfinexcom/bitfinex-api-go@v0.0.0-20200207184043-4d37e8d4be18/v2/websocket/client.go:466 +0x24a
github.com/bitfinexcom/bitfinex-api-go/v2/websocket.(*Client).listenUpstream(0xc0001f62c0, 0xc0000e9740)
	/go/pkg/mod/github.com/bitfinexcom/bitfinex-api-go@v0.0.0-20200207184043-4d37e8d4be18/v2/websocket/client.go:431 +0x19b
created by github.com/bitfinexcom/bitfinex-api-go/v2/websocket.(*Client).connectSocket
	/go/pkg/mod/github.com/bitfinexcom/bitfinex-api-go@v0.0.0-20200207184043-4d37e8d4be18/v2/websocket/client.go:398 +0x1e2

Steps to reproduce

Additional Notes:
@JacobPlaster
Copy link
Contributor

Thanks @calj, we will look into a fix for this.

@StylishTriangles
Copy link

I am running into this exact issue.
It seems that #219 hasn't resolved it for me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants
@calj @JacobPlaster @StylishTriangles and others