Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(headers): don't forward secure headers on protocol change #1605

Merged
merged 1 commit into from
Jul 19, 2022

Conversation

victal
Copy link

@victal victal commented Jul 19, 2022

Purpose

Backport of #1599 to the 2.x branch as it's a security fix (Resolves the issue at https://www.huntr.dev/bounties/db31e05b-ff10-4057-81a3-37445bf161cd/)

Additional information


  • I updated readme
  • I added unit test(s)

@jimmywarting jimmywarting merged commit fddad0e into node-fetch:2.x Jul 19, 2022
@victal victal deleted the fix/backport-1599 branch July 19, 2022 20:39
@victal
Copy link
Author

victal commented Jul 25, 2022

I forgot to ask earlier, but are 2.x versions released automatically when a PR is closed, the same as new 3.x versions?

If not, how/when can we have a new release published with this fix, and can we help with that in any way if needed?

@sseide
Copy link

sseide commented Jul 26, 2022

apparently the release is not done automatically as there is no v2.6.8 by now while these changes are merged for some days and the newer 3.x release with this fix is available for some days too.

@jimmywarting @cvalb Can someone please publish a new 2.x release to fix this security issue for all projects depending on this older version?

Many thanks in Advance,
S. Seide

@jimmywarting
Copy link
Collaborator

jimmywarting commented Jul 26, 2022

It should make an release automatically but i think it failed to publish at that one point for some reason.
@gr2m what would be the best way to re-trigger a release with semantic-release?

@dgmike
Copy link

dgmike commented Aug 2, 2022

Hello @jimmywarting @gr2m, a new version will rolled up to 2.x.x on npm?

@sseide
Copy link

sseide commented Aug 22, 2022

@gr2m or @jimmywarting - any news about a new 2.x npm release? It did not happen until now and looking at the npm download statistic in comparison to the 3.x release its much needed...

Thanks

@spacenate
Copy link

Thanks @victal for back-porting this! @jimmywarting @gr2m it would be awesome if a new 2.x version could be released on npm 🙏

@maralfol
Copy link

Hello,

Any update on 2.x release @jimmywarting @gr2m? I've been checking the releases and I don't think it was even triggered, or at least, it does not appear on the release history. It would be really helpful if anyone could trigger a new release 🙏🙏.
Apollo-core is using 2.6.7 in all versions and triggering it would fix it.
Thanks!

@github-actions
Copy link

🎉 This PR is included in version 2.6.8 🎉

The release is available on:

Your semantic-release bot 📦🚀

@iamart
Copy link

iamart commented Oct 1, 2024

This seemed to be a breaking change for us; after dep. update a server w/ 302 protocol redirect response makes fetch to return 401 error instead of following up with redirect and returning 200.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants