-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix "global is not defined" #1704
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
I think we should remove All in all: "use strict";
const { fetch, Headers, Request, Response } = globalThis;
module.exports = exports = fetch;
// Needed for TypeScript and Webpack.
if (fetch) {
exports.default = fetch;
}
exports.Headers = Headers;
exports.Request = Request;
exports.Response = Response; |
@jimmywarting what do you think about releasing this PR as is, and then someone can open a new PR for further changes? |
sure |
🎉 This PR is included in version 2.6.9 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Purpose
I think this was missed in #1534
Changes
Replace
global
->globalObject
Additional information
I get a
global is not defined
error otherwise. (octokit is still using this instead of isomorphic-fetch/cross-fetch)